51428 - Uninitialized Variable in nsEventStateManager.cpp

Status: VERIFIED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Lance Hankins]

There is a (very easy to fix) bug in the following method:

   nsEventStateManager::DispatchNewEvent (nsISupports *, nsIDOMEvent*)

This bug is around line 2566 in nsEventStateManager.cpp for the M17 baseline.   
The nsEventStatus variable "status" is declared and later used without being 
properly initialized to some value (so its value is garbage in some cases).   
This variable should be initialized with a value of nsEventStatus_eIgnore.   

We discovered this bug while attempting to manufacture DOM events from C++.   
Unless this variable's initial state is set to nsEventStatus_eIgnore, this 
manufacturing DOM events will not work correctly.    After changing the 
offending line of code, and rebuilding, things appear to work just fine.

Comment 1

[Lance Hankins]

Attachment: corrected version (search for "BEGIN NP CHANGE")

Comment 2

[Jan Carpenter]

Mass update of qa contact

Comment 3

[Johnny Stenback (:jst)]

Tom, could you have a look at this?

Comment 4

[Gervase Markham [:gerv]]

Confirming to get on joki's radar. Nominating rtm as a one-line, low risk fix. 
OK, so it's not a crasher, but it seems to break something for 
[e-mail] :-)

Gerv

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Unless you can point out a high visibility website that breaks because of this,
this is not going to make it into RTM. Marking [rtm-] for now.

I will make the first attachment into a proper patch.

Comment 6

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Patch done with "cvs diff -u"

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I am stealing this 'cos I have been running with this fix for a while and I
would like to get it checked in an stop messign up my diffs.

Comment 8

[Johnny Stenback (:jst)]

r=jst for the attached patch.

Comment 9

[vidur (gone)]

sr=vidur. See bug 48886 for additional comments.

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Patch checked in, marking fixed.

Comment 11

[Jan Carpenter]

lhankins, can you verify this?

Comment 12

[Vladimir Ermakov]

QA Contact Update

Comment 13

[Vladimir Ermakov]

verifying per developer's coments