514285 - horizontal scroll should not respect size of page title and/or url on WinMo

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090901 Fennec/1.0a3

...and urls are truncated on linux-maemo with build:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090901
Fennec/1.0b4pre

Steps to Reproduce: 
1. Go into protrait mode
2. Go to the nightly builds page or a google search via typing in the url
3. Go to your awesome bar history
4. Try to Scroll around

Actual Results:
The awesome bar results will be able to scroll horizontally if the title and/or url is longer than the size of the screen 

Expected Results:
Awesome bar results should only be able to scroll vertically no matter the length of the title or the url.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> The awesome bar results will be able to scroll horizontally if the title and/or
> url is longer than the size of the screen 

Why is this a problem?

Comment 2

[Aakash Desai [:aakashd]]

> Why is this a problem?

1. It's not consistent across platforms as the url cuts off at a certain length (I don't have a mobile device in front of me right now) for maemo and not for winmo.

2. There's more negatives (most sites don't have super large titles/urls that are particularly useful past a certain number of characters, more mistakes with scrolling/clicking on the entries, to see whether an entry is a bookmark requires scrolling to the right, looks like a lazy UI and probably more I can't think of off the top of my head right now) than positives (long title names and urls can be read).

Comment 3

[Stuart Parmenter]

agreed, it should never scroll horizontally

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

duplicate of 514285?

Comment 5

[Aakash Desai [:aakashd]]

This is bug 514285. What bug were you actually referring to?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Are we truncating at all in bookmarks? Bug 514285 is about making the truncation smarter.

Comment 7

[Aakash Desai [:aakashd]]

Ah, Vivien's bug is actually bug 507035 . If that's the case, then this is not a duplicate as the root cause of this bug is about horizontal scroll being allowed on the device. I'm adding this as a blocker for the other bug for the following reason:

The other bug is a general development bug that mentions the code should be able to truncate the url and/or title to the screen size. It'll indirectly fix this, but still leave the code open to horizontal scroll in the future via edge cases, IMO. We need to make sure horizontal scroll is not possible at all on the awesome bar and, in general, the chrome pieces that are affected by this.

The blocking-fennec? flag has been set for bug 507035 as well.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

fixed by bug 514462

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090922 Fennec/1.0a3

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090922
Fennec/1.0a3

Comment 10

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=11560 has been created to regression test this bug.