Closed
Bug 514299
Opened 17 years ago
Closed 9 years ago
preprocessor.py filters need to stack better, fix slashslash
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: taras.mozilla, Unassigned)
Details
Attachments
(1 file)
|
933 bytes,
patch
|
Pike
:
review-
|
Details | Diff | Splinter Review |
.sort prevents doing stuff like
#filter slashslash emptyLines
tuple magic on .split caused things to break on lines without '//'
Overall, I like this script. Took my input file from 75K to 48K. not bad for something that has to be read every startup.
Attachment #398246 -
Flags: review?(l10n)
Comment 1•17 years ago
|
||
Comment on attachment 398246 [details] [diff] [review]
fixes
r-, the slashslash stuff should be OK, but it should go along with a fix to test_filter_slashslash in config/tests/unit-Preprocessor.py.
The filter piece is broken, .keys doesn't return values in any given order. This does change specified behaviour, too, https://developer.mozilla.org/en/Build/Text_Preprocessor.
Not sure what's the right procedure to change that behaviour, post to .platform?
If we do, it should probably be "apply filters as specified" and probably more than once, too. No idea how to test that correctly.
Attachment #398246 -
Flags: review?(l10n) → review-
| Reporter | ||
Comment 2•17 years ago
|
||
Perhaps this isn't worth pursuing right this moment. slashslash busts "chrome://foo" strings in pref files.
Should probably tackle /* */ and // issues as part of a larger cleanup.
No longer blocks: 507288
Comment 3•9 years ago
|
||
8 years without activity on a preprocessor feature request. Going to call this INCOMPLETE.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INCOMPLETE
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•