Closed
Bug 514363
Opened 15 years ago
Closed 15 years ago
Port Bug 509625 [nsSessionStore.js should deal with browsers rather than tabpanels] to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
SeaMonkey
Session Restore
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
(Keywords: fixed-seamonkey2.0)
Attachments
(1 file, 1 obsolete file)
11.23 KB,
patch
|
misak.bugzilla
:
review+
misak.bugzilla
:
superreview+
kairo
:
approval-seamonkey2.0+
|
Details | Diff | Splinter Review |
Thinking about bug 508819, there doesn't seem to be a reason to use tabpanels at all. This bug was approved for 1.9.2 branch only on Firefox, but I can't see why it shouldn't be in 1.9.1
Attachment #398329 -
Flags: superreview?(neil)
Attachment #398329 -
Flags: review?(neil)
Comment 1•15 years ago
|
||
Comment on attachment 398329 [details] [diff] [review] patch >- let target = aEvent.originalTarget; >- let panelID = target.linkedPanel; >- let ownerDoc = target.ownerDocument; >- let bindingParent = ownerDoc.getBindingParent(target); >- let tabpanel = >- ownerDoc.getAnonymousElementByAttribute(bindingParent, "id", >- panelID); >+ let browser = aEvent.originalTarget.linkedBrowser; Just merge attachment 398327 [details] [diff] [review] in. >- onTabLoad: function sss_onTabLoad(aWindow, aPanel, aEvent) { >+ onTabLoad: function sss_onTabLoad(aWindow, aBrowser, aEvent) { Nit: trailing space >- * Called when a tabpanel sends the "input" notification >+ * Called when a browser sends the "input" notification Nit: trailing space >- * Called when a tabpanel sends a "scroll" notification >+ * Called when a browser sends a "scroll" notification Nit: trailing space
Attachment #398329 -
Flags: superreview?(neil)
Attachment #398329 -
Flags: superreview+
Attachment #398329 -
Flags: review?(neil)
Attachment #398329 -
Flags: review+
Assignee | ||
Comment 3•15 years ago
|
||
For checkin, nits fixed, carrying forward r+ and sr+ from Neil.
Attachment #398329 -
Attachment is obsolete: true
Attachment #398355 -
Flags: superreview+
Attachment #398355 -
Flags: review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Updated•15 years ago
|
Attachment #398355 -
Flags: approval-seamonkey2.0?
Updated•15 years ago
|
Attachment #398355 -
Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
Comment 4•15 years ago
|
||
http://hg.mozilla.org/comm-central/rev/9879857ebd93
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0
Comment 5•15 years ago
|
||
Adding fixed-seamonkey2.0 keyword so the queries for approved but not fixed bugs don't catch that bug.
Keywords: fixed-seamonkey2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•