514363 - Port Bug 509625 [nsSessionStore.js should deal with browsers rather than tabpanels] to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch

Thinking about bug 508819, there doesn't seem to be a reason to use tabpanels
at all.

This bug was approved for 1.9.2 branch only on Firefox, but I can't see why it shouldn't be in 1.9.1

Comment 1

[[e-mail]]

Comment on attachment 398329 [details] [diff] [review]
patch

>-        let target = aEvent.originalTarget;
>-        let panelID = target.linkedPanel;
>-        let ownerDoc = target.ownerDocument;
>-        let bindingParent = ownerDoc.getBindingParent(target);
>-        let tabpanel =
>-          ownerDoc.getAnonymousElementByAttribute(bindingParent, "id",
>-                                                  panelID);
>+        let browser = aEvent.originalTarget.linkedBrowser;
Just merge attachment 398327 [details] [diff] [review] in.

>-  onTabLoad: function sss_onTabLoad(aWindow, aPanel, aEvent) {
>+  onTabLoad: function sss_onTabLoad(aWindow, aBrowser, aEvent) { 
Nit: trailing space

>-   * Called when a tabpanel sends the "input" notification
>+   * Called when a browser sends the "input" notification 
Nit: trailing space

>-   * Called when a tabpanel sends a "scroll" notification
>+   * Called when a browser sends a "scroll" notification 
Nit: trailing space

Comment 3

[Misak Khachatryan]

Attachment: patch for checkin

For checkin, nits fixed, carrying forward r+ and sr+ from Neil.

Comment 4

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/9879857ebd93

Comment 5

[Robert Kaiser]

Adding fixed-seamonkey2.0 keyword so the queries for approved but not fixed bugs don't catch that bug.