No quit dialog when multiple windows are open

RESOLVED FIXED in seamonkey2.0

Status

SeaMonkey
Session Restore
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Misak Khachatryan)

Tracking

({fixed-seamonkey2.0})

Trunk
seamonkey2.0
fixed-seamonkey2.0
Bug Flags:
wanted-seamonkey2.0 +
blocking-seamonkey2.0b2 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

2.29 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
neil@parkwaycc.co.uk
: ui-review+
neil@parkwaycc.co.uk
: approval-seamonkey2.0+
Details | Diff | Splinter Review
736 bytes, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
neil@parkwaycc.co.uk
: approval-seamonkey2.0+
Details | Diff | Splinter Review
(Reporter)

Description

8 years ago
nsSuiteGlue.js has a reference to chrome://browser/locale/quitDialog.properties but this file does not exist in SeaMonkey. Instead we need to create one in the communicator locale and update nsSuiteGlue.js to point to it.

Comment 1

8 years ago
I wonder if we might actually have the strings in one of our files already and just missed to correct the URL, actually.
(Assignee)

Comment 2

8 years ago
Actually suite/locales/en-US/chrome/common/quitDialog.properties file was missing, so string changes required :(
Assignee: nobody → misak
Status: NEW → ASSIGNED
Keywords: helpwanted
(Assignee)

Comment 3

8 years ago
Created attachment 398595 [details] [diff] [review]
fix
[Checkin: Comment 6]
Attachment #398595 - Flags: ui-review?(neil)
Attachment #398595 - Flags: superreview?(neil)
Attachment #398595 - Flags: review?(neil)
(Assignee)

Updated

8 years ago
Flags: wanted-seamonkey2.0?
Flags: blocking-seamonkey2.0b2?
(Assignee)

Comment 4

8 years ago
also we might want to port Bug 354894 too, I'll do it after beta 2
(Reporter)

Updated

8 years ago
Attachment #398595 - Flags: ui-review?(neil)
Attachment #398595 - Flags: ui-review+
Attachment #398595 - Flags: superreview?(neil)
Attachment #398595 - Flags: superreview+
Attachment #398595 - Flags: review?(neil)
Attachment #398595 - Flags: review+
Attachment #398595 - Flags: approval-seamonkey2.0+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed

Comment 5

8 years ago
You can't block 2.0b2 any more, it has been cut, but yes, we want this for 2.0
Flags: wanted-seamonkey2.0?
Flags: wanted-seamonkey2.0+
Flags: blocking-seamonkey2.0b2?
Flags: blocking-seamonkey2.0b2-
Comment on attachment 398595 [details] [diff] [review]
fix
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/f5f47aae6455
Attachment #398595 - Attachment description: fix → fix [Checkin: Comment 6]
Keywords: checkin-needed
Target Milestone: --- → seamonkey2.0
(Assignee)

Comment 7

8 years ago
This fix was working for me at the moment of submitting, but somehow not now :( Current behavior is on quit SM prompts tab close warning for each window and then quit prompt. Can't figure out why.
(Assignee)

Comment 8

8 years ago
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090907 NOT Firefox/2.0.0.20 Lightning/1.0pre SeaMonkey/2.0pre ID:20090907094702


Sorry, forgot my Build iD
(Reporter)

Comment 9

8 years ago
It's random, unfortunately; it just depends on whether nsSuiteGlue or nsTryToClose has been registered first. (nsTryToClose is the component that calls the individual prompt for each window.)
(Reporter)

Comment 10

8 years ago
So, according to gavin, Firefox doesn't set window.tryToClose in its browsers, so that only session restore prompts when you're trying to quit.
(Assignee)

Comment 11

8 years ago
Yes, figured that out too, fix is in patch for bug 515006
(Assignee)

Comment 12

8 years ago
Created attachment 399397 [details] [diff] [review]
don't set window.tryToClose in browser

It seems this one liner is fixing this bug. No need to wait for bug 515006
Attachment #399397 - Flags: superreview?(neil)
Attachment #399397 - Flags: review?(neil)
Attachment #399397 - Flags: approval-seamonkey2.0?
(Reporter)

Updated

8 years ago
Attachment #399397 - Flags: superreview?(neil)
Attachment #399397 - Flags: superreview-
Attachment #399397 - Flags: review?(neil)
Attachment #399397 - Flags: approval-seamonkey2.0?
(Reporter)

Comment 13

8 years ago
Comment on attachment 399397 [details] [diff] [review]
don't set window.tryToClose in browser

This isn't quite right, you need to change BrowserTryToCloseWindow too.
(Assignee)

Comment 14

8 years ago
Created attachment 399425 [details] [diff] [review]
right fix
[Checkin: Comment 15]

Sorry, this is the right one.
Attachment #399397 - Attachment is obsolete: true
Attachment #399425 - Flags: superreview?(neil)
Attachment #399425 - Flags: review?(neil)
Attachment #399425 - Flags: approval-seamonkey2.0?
(Reporter)

Updated

8 years ago
Attachment #399425 - Flags: superreview?(neil)
Attachment #399425 - Flags: superreview+
Attachment #399425 - Flags: review?(neil)
Attachment #399425 - Flags: review+
Attachment #399425 - Flags: approval-seamonkey2.0?
Attachment #399425 - Flags: approval-seamonkey2.0+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Comment on attachment 399425 [details] [diff] [review]
right fix
[Checkin: Comment 15]


http://hg.mozilla.org/comm-central/rev/d45144dc165c
Attachment #399425 - Attachment description: right fix → right fix [Checkin: Comment 15]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

8 years ago
Keywords: fixed-seamonkey2.0

Comment 16

8 years ago
Hello,

Do I take it that the old feature to give a warning dialog box before quitting when multiple windows or tabs are open is supposed to have been restored? I am running 
Build identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.7) Gecko/20100105 SeaMonkey/2.0.2

... and keep accidentally quitting with no dialog when hitting Command-Q by mistake (intending Command-W).
(Reporter)

Comment 17

8 years ago
(In reply to comment #16)
> Do I take it that the old feature to give a warning dialog box before quitting
> when multiple windows or tabs are open is supposed to have been restored?
Yes, unless your startup preference is set to restore previous session.
You need to log in before you can comment on or make changes to this bug.