514415 - Expose NetUtil's reference to nsIIOService

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Don't know if we should just mirror the nsIIOService interface on NetUtil instead, but anything that makes it so I'm not importing both NetUtil and fetching and caching my own reference to nsIIOService is good enough my purposes :)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Why not ioService?

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

(In reply to comment #1)
> Why not ioService?

Verbosity and ios' frequent appearance as a variable name in JS: http://mxr.mozilla.org/mozilla-central/search?string=ios.&find=\.js&findi=\.js&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Which would you prefer?

Comment 3

[Boris Zbarsky [:bzbarsky]]

I'd prefer ioService, but this might be a question better asked of someone more familiar with our JS api conventions.

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

IRC concurs.

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 398507 [details] [diff] [review]
Patch

I'm betting bz is fine with me reviewing this code since I've touched pretty much all of it.  Moving him to sr since this is a new API addition.

>+    /**
>+     * Returns a reference to nsIIOService.
>+     */
nit: @return a reference to nsIIOService.

>+    get ioService() {
>+        return ioService;
>+    },
I wonder if we should just do defineGetter on this object instead of globally (and update references elsewhere).  Seems like less indirection, but I don't care either way.

r=sdwilsh

Comment 6

[Ryan Flint [:rflint] (ping via IRC for reviews)]

http://hg.mozilla.org/mozilla-central/rev/f2f941b8bff8