Closed Bug 514496 Opened 15 years ago Closed 15 years ago

NJ: Add more x64 conditional opcode support (ov, cmov)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

LIR_ov
7.48 KB, patch
rreitmai
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
This patch adds more options to LIR_q?cmov and enables LIR_ov. The extra X64_cmovq* entries in X64Opcode are there to document the encoding.
Attachment #398436 - Flags: review?(edwsmith)
Attached patch LIR_ov — — Splinter Review 
Bah, extracted patch wrong - LIR_ov goes in asm_cmp not asm_cmp_imm
Attachment #398436 - Attachment is obsolete: true
Attachment #398438 - Flags: review?(edwsmith)
Attachment #398436 - Flags: review?(edwsmith)
Attachment #398438 - Flags: review?(edwsmith) → review?(rreitmai)
Attachment #398438 - Flags: review?(rreitmai) → review+
Comment on attachment 398438 [details] [diff] [review]
LIR_ov 

Did you want a 32b move instruction for line 695?

i.e.
  X64_cmovqno, X64_cmovne   <== cmovqne instead
Good catch, thanks -- indeed that's wrong.

http://hg.mozilla.org/tracemonkey/rev/11e017a0bcfe
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/11e017a0bcfe
Assignee: general → dvander
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: