514503 - NJ: Add sanity check filter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: sanity checker

This is right from CodegenLIR.cpp for the most part. Blocking our x64 port because we had a bajillion typing errors so I think it's important for us to turn this thing on all the time.

Comment 1

[Andreas Gal :gal]

Comment on attachment 398443 [details] [diff] [review]
sanity checker

Stealing this from Ed. This moves CodeGen.cpp code into nanojit where we can share it with Adobe. I am sure he is ok with that.

Comment 2

[Edwin Smith]

Comment on attachment 398443 [details] [diff] [review]
sanity checker

Cool, but why not just promote the whole ValidateWriter from CodegenLIR.cpp?  I like the new name SanityFilter, and there's nothing in ValidateWriter that should be Tamarin specific.

Comment 3

[Edwin Smith]

(In reply to comment #0)
> Created an attachment (id=398443) [details]
> sanity checker
> 
> This is right from CodegenLIR.cpp for the most part. Blocking our x64 port
> because we had a bajillion typing errors so I think it's important for us to
> turn this thing on all the time.

yeah, this thing saved me many many man hours of debugging time.

jseward was prototyping an even smarter type checker that could replace this one down the road.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/tracemonkey/rev/4334662cc4de

I was trying to take a minimal subset - will do a follow-up patch for the rest next week.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/4334662cc4de -- I read comment 4 as this not being FIXED.

Comment 6

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/560bb82dae27