The default bug view has changed. See this FAQ.

NJ: Add sanity check filter

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: dvander, Unassigned)

Tracking

unspecified
x86
Linux
Points:
---
Dependency tree / graph
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 398443 [details] [diff] [review]
sanity checker

This is right from CodegenLIR.cpp for the most part. Blocking our x64 port because we had a bajillion typing errors so I think it's important for us to turn this thing on all the time.
Attachment #398443 - Flags: review?(edwsmith)
(Reporter)

Updated

8 years ago
Blocks: 514548

Updated

8 years ago
Attachment #398443 - Flags: review+

Comment 1

8 years ago
Comment on attachment 398443 [details] [diff] [review]
sanity checker

Stealing this from Ed. This moves CodeGen.cpp code into nanojit where we can share it with Adobe. I am sure he is ok with that.
(Reporter)

Updated

8 years ago
Blocks: 513844

Comment 2

8 years ago
Comment on attachment 398443 [details] [diff] [review]
sanity checker

Cool, but why not just promote the whole ValidateWriter from CodegenLIR.cpp?  I like the new name SanityFilter, and there's nothing in ValidateWriter that should be Tamarin specific.
Attachment #398443 - Flags: review?(edwsmith) → review+

Comment 3

8 years ago
(In reply to comment #0)
> Created an attachment (id=398443) [details]
> sanity checker
> 
> This is right from CodegenLIR.cpp for the most part. Blocking our x64 port
> because we had a bajillion typing errors so I think it's important for us to
> turn this thing on all the time.

yeah, this thing saved me many many man hours of debugging time.

jseward was prototyping an even smarter type checker that could replace this one down the road.
(Reporter)

Comment 4

8 years ago
http://hg.mozilla.org/tracemonkey/rev/4334662cc4de

I was trying to take a minimal subset - will do a follow-up patch for the rest next week.
http://hg.mozilla.org/mozilla-central/rev/4334662cc4de -- I read comment 4 as this not being FIXED.

Comment 6

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/560bb82dae27
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.