Closed
Bug 514514
Opened 15 years ago
Closed 15 years ago
[mozmill] testGoogleSuggestedTerms fails due to different HTML markup between release and nightly builds
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
3.16 KB,
patch
|
aakashd
:
review+
|
Details | Diff | Splinter Review |
Test Failed : testGoogleSuggestedTerms in c:\mozilla\tests\firefox\testContent\t
estGoogleSuggestions.js
ERROR - Test Failure: {'exception': {'message': "timeout exceeded for waitForEle
ment XPath: /html/body/span[@id='main']/center/span[@id='body']/center/form/tabl
e[2]/tbody/tr[2]/td", 'lineNumber': 306
Google supplies different markup to us depending on the version of the browser you are using. That means releases will need another lookup string as nightly builds. We should differentiate between those two variants and build the lookup string appropriately.
Aakash, can you please take a look at it?
Assignee | ||
Comment 1•15 years ago
|
||
Aakash, would you have time to check this failure? Would be nice to see it fixed.
Comment 2•15 years ago
|
||
Hm, you're right. After a little investigation, I got the following xpath id's for the first
Namoroka:
new elementslib.XPath(controller.tabs.activeTab, "/html/body/center/form/table[2]/tbody/tr[2]/td")
Firefox:
new elementslib.XPath(controller.tabs.activeTab, "/html/body/span[@id='main']/center/span[@id='body']/center/form/table[2]/tbody/tr[2]/td");
Minefield:
new elementslib.XPath(controller.tabs.activeTab, "/html/body/center/form/table[2]/tbody/tr[2]/td")
Also, a new community member, Shirish also noted that this is locale dependent as well. If that's the case, the string that we're using might not translate correctly and bring up no results...which will fail the testscript as well. What'd you like to do from here?
Assignee | ||
Comment 3•15 years ago
|
||
There is no redirect depending on the locale and the XPath expression looks always the same for me also in localized builds. So can you point us to the report from Shirish?
I would say we should only differentiate between the two expression above. So we match branded and non-branded builds. If we have a problem with another locale we should investigate first.
Assignee | ||
Comment 4•15 years ago
|
||
Once bug 521458 has been landed we can use the platform version to determine if we have a release build or a non-branded one. We simply have to check if "pre" is existent inside the version identifier.
Depends on: 521458
Assignee | ||
Comment 5•15 years ago
|
||
That solves our problem with release and nightly builds.
Assignee: adesai → hskupin
Attachment #406448 -
Flags: review?(adesai)
Comment 6•15 years ago
|
||
Comment on attachment 406448 [details] [diff] [review]
Patch v1
The code looks right and it passes across Minefield, Namoroka and Firefox 3.5 on XP and OSX. Thanks for doing this, Henrik.
Attachment #406448 -
Flags: review?(adesai) → review+
Assignee | ||
Comment 7•15 years ago
|
||
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/6c393011d32d
http://hg.mozilla.org/qa/mozmill-tests/rev/724eccaf231f
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•14 years ago
|
||
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: General → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: general → mozmill-tests
Version: Trunk → unspecified
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•