Closed
Bug 514542
Opened 17 years ago
Closed 16 years ago
Satchel unit tests expect preferences to be set to specific values that are not the core values
Categories
(Toolkit :: Form Manager, defect)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: standard8, Assigned: mak)
References
Details
(Whiteboard: [fixed by bug 520165])
I just enabled satchel in Thunderbird on trunk (bug 510377). Two unit tests failed because Thunderbird's default value of browser.history_expire_days was set to 9 (as per all.js); browser.history_expire_days_min and browser.history_expire_sites have no value in all.js.
NEXT ERROR TEST-UNEXPECTED-FAIL | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
### XPCOM_MEM_LEAK_LOG defined -- logging leaks to /tmp/runxpcshelltests_leaks.log
TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-PASS | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js | [run_test : 127] true == true
TEST-PASS | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js | [countAllEntries : 45] true == true
TEST-PASS | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js | [run_test : 128] 50 == 50
TEST-PASS | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js | [run_test : 129] true == true
TEST-PASS | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js | [run_test : 135] 50 == 50
NEXT ERROR TEST-UNEXPECTED-FAIL | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js | 45 == 49 - See following stack:
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_throw :: line 197
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_check_eq :: line 227
JS frame :: /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_autocomplete.js :: run_test :: line 143
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: _execute_test :: line 125
JS frame :: -e :: <TOP_LEVEL> :: line 1
TEST-INFO | (xpcshell/head.js) | exiting test
NEXT ERROR TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | FAILED in test #3 -- 2147500036
NEXT ERROR TEST-UNEXPECTED-FAIL | /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_expire.js | false == true - See following stack:
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_throw :: line 197
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_check_eq :: line 227
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_check_true :: line 239
JS frame :: /buildbot/linux-comm-central-check/build/objdir/mozilla/_tests/xpcshell/test_satchel/unit/test_expire.js :: run_test :: line 131
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: _execute_test :: line 125
JS frame :: -e :: <TOP_LEVEL> :: line 1
TEST-INFO | (xpcshell/head.js) | exiting test
NEXT ERROR TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | FAILED in test #2 -- 2147500036
We've fixed this at least temporarily in all-thunderbird.js, however the tests should really be preference value independent or all the separately specified instances of the prefs should be merged into all.js so that xulrunner apps can have tests run and pass (or even better, both).
Comment 1•16 years ago
|
||
Fixed by bug 520165 taking away the history pref so the tests couldn't use it anymore.
Updated•16 years ago
|
Assignee: nobody → mak77
Flags: in-testsuite-
Whiteboard: [fixed by bug 520165]
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•