Closed
Bug 514674
Opened 15 years ago
Closed 15 years ago
Out-of-date check for obsolete Flash in detect-flash.js has hardcoded message in it
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: pascalc, Assigned: pascalc)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.54 KB,
patch
|
morgamic
:
review+
|
Details | Diff | Splinter Review |
The warning message about Flash being outdated ('You should update Adobe Flash right now.Firefox is up to date, but your current version of Flash can cause security and stability issues. Please install the free update') is hardcoded in the library. For translation purposes, we need these sentences to be in variables that can be redifined in the locale's page. I am attaching a patch doing that, it puts the two sentences in variables (FlashAlertTitle and FlashAlertText) and falls back to English text defined in detect-flash.js if these variables are not defined in the calling page.
Attachment #398667 -
Flags: review?(morgamic)
Comment 1•15 years ago
|
||
Looks right to me; Mike, can we get a quick review?
Assignee: nobody → pascalc
Updated•15 years ago
|
Summary: Out of date check for obsolete Flash in detect-flash.js has hardcoded message in it → Out-of-date check for obsolete Flash in detect-flash.js has hardcoded message in it
Assignee | ||
Comment 2•15 years ago
|
||
updated patch to say 'Flash Player' instead of just 'Flash'
Attachment #398667 -
Attachment is obsolete: true
Attachment #398853 -
Flags: review?(morgamic)
Attachment #398667 -
Flags: review?(morgamic)
Updated•15 years ago
|
Attachment #398853 -
Flags: review?(morgamic) → review+
Comment 3•15 years ago
|
||
Comment on attachment 398853 [details] [diff] [review] update patch to say 'Flash Player' instead of just 'Flash' Works for me.
Assignee | ||
Comment 4•15 years ago
|
||
committed in r50957
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
Verified FIXED on https://www-trunk.stage.mozilla.com/en-US/firefox/3.5.3/whatsnew/ using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729) with Flash Player 10.0 r22 (outdated version).
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•12 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•