514674 - Out-of-date check for obsolete Flash in detect-flash.js has hardcoded message in it

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Attachment: patch turning hardcoded strings into variables

The warning message about Flash being outdated ('You should update Adobe Flash right now.Firefox is up to date, but your current version of Flash can cause security and stability issues.  Please install the free update') is hardcoded in the library.

For translation purposes, we need these sentences to be in variables that can be redifined in the locale's page.

I am attaching a patch doing that, it puts the two sentences in variables (FlashAlertTitle and FlashAlertText) and falls back to English text defined in detect-flash.js if these variables are not defined in the calling page.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Looks right to me; Mike, can we get a quick review?

Comment 2

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Attachment: update patch to say 'Flash Player' instead of just 'Flash'

updated patch to say 'Flash Player' instead of just 'Flash'

Comment 3

[Michael Morgan [:morgamic]]

Comment on attachment 398853 [details] [diff] [review]
update patch to say 'Flash Player' instead of just 'Flash'

Works for me.

Comment 4

[Pascal Chevrel:pascalc (PTO until Sept 2)]

committed in r50957

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://www-trunk.stage.mozilla.com/en-US/firefox/3.5.3/whatsnew/ using Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729) with Flash Player 10.0 r22 (outdated version).