Remove UI and backend for keep unread messages only

RESOLVED FIXED in Thunderbird 47.0

Status

defect
--
minor
RESOLVED FIXED
10 years ago
4 years ago

People

(Reporter: standard8, Assigned: aceman)

Tracking

Trunk
Thunderbird 47.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Partial Patch (obsolete) — Splinter Review
Following on from bug 499306 and bug 326584 we should remove the (hidden) UI and backend for keepUnreadMessagesOnly. We only want to do this post TB 3 so people have a chance to alter they settings if really necessary.

UI patch attached, needs backend fiddling with as well.
Severity: normal → minor
Assignee: mbanner → nobody
Whiteboard: [patchlove][has draft patch]
Target Milestone: Thunderbird 3.1a1 → ---
Is there general agreement that this feature should be removed? Also for Seamonkey?
I think so, it's been hidden forever.
The reason for hiding it in bug 326584 was merely that removing the checkbox entirely broke an obscure interaction between the UI and the backend. It appears to be a rather dangerous option given that it deletes all read messages when checked (i.e., iirc, ignores any of the time-based restrictions), and I'm not sure what the actual use case might be for this option (I think there was some motivation to use it for newsgroups, where the reading end is read-only, but it's definitely questionable for mail).
(In reply to Magnus Melin from comment #2)
> I think so, it's been hidden forever.
Yeah, it was hidden, but maybe the idea was to fix the logic and expose it again.

But if nobody could come up with a use for this feature and how to fix the logic, then it probably can be removed.
Assignee: nobody → acelists
(In reply to :aceman from comment #4)
> (In reply to Magnus Melin from comment #2)
> > I think so, it's been hidden forever.
> Yeah, it was hidden, but maybe the idea was to fix the logic and expose it
> again.

Nope, as per comment 0 it was just in case we found that users needed to toggle it manually.
There seems to be quite a lot of references to this option, try http://mxr.mozilla.org/comm-central/ident?i=keepUnreadMessagesOnly . But now is probably a good time to kill it off as no users wanting the feature appeared in the 6 years the bug is open.
Posted patch full patchSplinter Review
Try run: https://hg.mozilla.org/try-comm-central/rev/4261be7853ae
Attachment #398761 - Attachment is obsolete: true
Attachment #8665163 - Flags: review?(neil)
Attachment #8665163 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Whiteboard: [patchlove][has draft patch]
Comment on attachment 8665163 [details] [diff] [review]
full patch

Review of attachment 8665163 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #8665163 - Flags: review?(mkmelin+mozilla) → review+
Attachment #8665163 - Flags: review?(rkent)
Comment on attachment 8665163 [details] [diff] [review]
full patch

Review of attachment 8665163 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8665163 - Flags: review?(rkent) → review+
Thanks.
Keywords: checkin-needed
Attachment #8665163 - Flags: review?(neil)
https://hg.mozilla.org/comm-central/rev/caa7a0d640e1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
You need to log in before you can comment on or make changes to this bug.