514762 - Remove UI and backend for keep unread messages only

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Mark Banner (:standard8)]

Attachment: Partial Patch

Following on from bug 499306 and bug 326584 we should remove the (hidden) UI and backend for keepUnreadMessagesOnly. We only want to do this post TB 3 so people have a chance to alter they settings if really necessary.

UI patch attached, needs backend fiddling with as well.

Comment 1

[:aceman]

Is there general agreement that this feature should be removed? Also for Seamonkey?

Comment 2

[Magnus Melin [:mkmelin]]

I think so, it's been hidden forever.

Comment 3

[rsx11m]

The reason for hiding it in bug 326584 was merely that removing the checkbox entirely broke an obscure interaction between the UI and the backend. It appears to be a rather dangerous option given that it deletes all read messages when checked (i.e., iirc, ignores any of the time-based restrictions), and I'm not sure what the actual use case might be for this option (I think there was some motivation to use it for newsgroups, where the reading end is read-only, but it's definitely questionable for mail).

Comment 4

[:aceman]

(In reply to Magnus Melin from comment #2)
> I think so, it's been hidden forever.
Yeah, it was hidden, but maybe the idea was to fix the logic and expose it again.

But if nobody could come up with a use for this feature and how to fix the logic, then it probably can be removed.

Comment 5

[Mark Banner (:standard8)]

(In reply to :aceman from comment #4)
> (In reply to Magnus Melin from comment #2)
> > I think so, it's been hidden forever.
> Yeah, it was hidden, but maybe the idea was to fix the logic and expose it
> again.

Nope, as per comment 0 it was just in case we found that users needed to toggle it manually.

Comment 6

[:aceman]

There seems to be quite a lot of references to this option, try http://mxr.mozilla.org/comm-central/ident?i=keepUnreadMessagesOnly . But now is probably a good time to kill it off as no users wanting the feature appeared in the 6 years the bug is open.

Comment 7

[:aceman]

Attachment: full patch

Try run: https://hg.mozilla.org/try-comm-central/rev/4261be7853ae

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 8665163 [details] [diff] [review]
full patch

Review of attachment 8665163 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 9

[Kent James (:rkent)]

Comment on attachment 8665163 [details] [diff] [review]
full patch

Review of attachment 8665163 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 10

[:aceman]

Thanks.

Comment 11

[:aceman]

https://hg.mozilla.org/comm-central/rev/caa7a0d640e1