Closed Bug 514816 Opened 15 years ago Closed 15 years ago

Get tests from bug 464620 for various XSS bugs working

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: reed, Assigned: zpao)

References

Details

(Whiteboard: [sg:want P1])

Attachments

(1 file)

The tests from bug 464620 for bug 459906, bug 461743, bug 463205, and bug 464620 are broken and need to be fixed. I left them on trunk for now, but I disabled them.

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_459906.js | rich textarea's content correctly duplicated - Got , expected <b>Unique:</b> 1252127536690
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_459906.js | XSS exploit prevented! - Got , expected localhost
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_461743.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_464620_a.js | Timed out
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_464620_b.js | Timed out
Flags: blocking-firefox3.6?
Whiteboard: [sg:want P1]
Summary: Get tests for XSS bugs from bug 464620 working → Get tests from bug 464620 for various XSS bugs working
I'm afraid I don't have time to look at this anytime soon.
Assignee: zeniko → nobody
Reed: why do you think this blocks?
Flags: wanted-firefox3.6+
Flags: blocking-firefox3.6?
Flags: blocking-firefox3.6-
(In reply to comment #2)
> Reed: why do you think this blocks?

It's a blocker in the sense that somebody needs to do this sooner rather than later, as we have nothing right now ensuring we don't end up with the same bugs in the future due to lack of working tests. Somebody should probably just be assigned to work on this and get all the tests working, but it doesn't have to actually block a release.
zpao, think you might have time as you've been poking around in the session restore stuff lately?
I missed this in my bugmail. I'll put it in my todo list, but behind my work targeted for 3.6. Can somebody CC me on bugs 461743, 463205, and 464620 since I don't have security bits?
Assignee: nobody → paul
(In reply to comment #5)
> I missed this in my bugmail. I'll put it in my todo list, but behind my work
> targeted for 3.6. Can somebody CC me on bugs 461743, 463205, and 464620 since I
> don't have security bits?

Done.
I assume bugzilla handles private bugs depending on public bugs, but since I'm not sure I won't mark as such.

At least some of these are failing due to bug 520891 (which happens when deserializing history entries for frames whose principal is about:blank... or something that mrbkap understands much better than I).
Attached patch Patch v0.1Splinter Review
Since that other bug landed, the tests all work. Running on try right now, but they pass locally.
Attachment #405308 - Flags: review?(zeniko)
Attachment #405308 - Flags: review?(zeniko) → review+
Comment on attachment 405308 [details] [diff] [review]
Patch v0.1

Thanks for looking into this.
Pushed http://hg.mozilla.org/mozilla-central/rev/2060913424ed. Will push to 1.9.2 when/if bug 520891 lands there.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Group: core-security
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: