514832 - SUFeedURL must be present at launch

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Mehmet]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; de-de) AppleWebKit/531.9 (KHTML, like Gecko) Version/4.0.3 Safari/531.9
Build Identifier: 2009-09-01-22-2.0-M1.9 until 2009-09-04-22-2.0-M1.9

Hello Camino Team,

Camino nighly crashes immediatly on Leopard (10.5.8) after I done a clean new installation of a Version 2009-09-01-22-2.0-M1.9 or higher.

Regards
Mehmet

Reproducible: Always

Steps to Reproduce:
1. Deinstall Camino 2 nighly completely (all folders, plist,...!!)
2. Install one of the versions from 2009-09-01-22-2.0-M1.9 until 2009-09-04-22-2.0-M1.9
3. start Camino
Actual Results:  
Camino 2 nightly crashes immediatly after start (Breakpad comes up) !!!

Expected Results:  
Camino 2 nightly should not crash !!!

When I install one of the Versions over an existing (older) Camino-Version, there is NO problem !!!

Comment 1

[Mehmet]

CrashID=bp-40988e19-bea7-49c0-af30-625f22090905

Comment 2

[philippe (part-time)]

I can get the 2.0b4pre (1.9.0.15pre 2009083122) build to start, but not the 2.0b4pre (1.9.0.15pre 2009090122).

It is the org.mozilla.camino.plist, btw. If that file exist, the browser starts up fine.

The console logs the following:
Application Specific Information:
*** Terminating app due to uncaught exception 'SUNoFeedURL', reason: 'You must specify the URL of the appcast as the SUFeedURL key in either the Info.plist or the user defaults!'


http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=Camino&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2009-08-31+22%3A00%3A00&maxdate=2009-09-01+22%3A00%3A00&cvsroot=%2Fcvsroot

--> Stuarts checking of the Sparkle upgrade

Comment 3

[Stuart Morgan]

Ugh. The feed URL used to only be checked when an update was about to happen, but now it's during SUUpdater init, which for us means MainMenu loading. We need a dummy in the plist, an upstream change, or to create the SUUpdater manually later in startup.

Comment 4

[Stuart Morgan]

Making the SUUpdater manually turned out not to be a real option, since we use the updater object itself to set the prefs so we aren't hard-coding Sparkle pref strings. And as tempted as I am to fix this upstream (I think they are checking this at the wrong time, since it doesn't protect against insecure URLs set via pref), the fact that what we are doing is so unusual would likely leave us open to future breakage anyway.

I checked in a dummy ("https://") to satisfy the startup-time check; it'll still be set to something real by the time it would actually be used. Fixed on trunk and CAMINO_2_0_BRANCH.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Why weren't we seeing this on the tinderboxen?

Comment 6

[Stuart Morgan]

I'm guessing we don't nuke org.mozilla.camino.plist