Closed Bug 514917 Opened 15 years ago Closed 15 years ago

-moz-box-shadow is not calculated properly with absolute children

Categories

(Core :: Web Painting, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: stream, Assigned: dbaron)

References

Details

(Keywords: css3, testcase)

Attachments

(2 files, 1 obsolete file)

Attached file testcase
The shadow is painted correctly but takes even more invisible space if the same children element is not positioned absolute.

This causes unneeded scrollbars.
OS: Windows XP → All
Hardware: x86 → All
ComputeOutlineAndEffectsRect (in nsFrame.cpp) needs to add shadows to the frame's rect instead of the overflow rect.  (And nsDisplayBoxShadowOuter::GetBounds could perhaps be more conservative, though that doesn't matter except for performance, I think.)
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #414602 - Flags: review?(roc)
Attached patch patchSplinter Review
Er, except I should have used (0,0) instead of the top/left of the overflow rect.
Attachment #414602 - Attachment is obsolete: true
Attachment #414621 - Flags: review?(roc)
Any chance for landing on 3.6?
http://hg.mozilla.org/mozilla-central/rev/a26df386758f
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: