514996 - 2nd parameter of Gestalt() is SInt32, not long

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Makoto Kato [:m_kato]]

According to http://developer.apple.com/mac/library/documentation/Carbon/Reference/Gestalt_Manager/Reference/reference.html#//apple_ref/c/func/Gestalt, 2nd parameter of Gestalt() is SInt32*.

But some codes in Mozilla tree use "long*" type.  So this will cause build break for 64-bit build.

/chrome/src/nsChromeRegistry.cpp (View Hg log or Hg annotations)
    * line 1657 -- if ((Gestalt(gestaltSystemVersionMajor, &majorVersion) == noErr) &&
    * line 1658 -- (Gestalt(gestaltSystemVersionMinor, &minorVersion) == noErr)) {

/toolkit/xre/nsNativeAppSupportCocoa.mm (View Hg log or Hg annotations)
    * line 110 -- OSErr err = ::Gestalt (gestaltSystemVersion, &response);

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch v1

Comment 2

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/c5fad7d529ec