Closed
Bug 514996
Opened 15 years ago
Closed 15 years ago
2nd parameter of Gestalt() is SInt32, not long
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
1.94 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
According to http://developer.apple.com/mac/library/documentation/Carbon/Reference/Gestalt_Manager/Reference/reference.html#//apple_ref/c/func/Gestalt, 2nd parameter of Gestalt() is SInt32*.
But some codes in Mozilla tree use "long*" type. So this will cause build break for 64-bit build.
/chrome/src/nsChromeRegistry.cpp (View Hg log or Hg annotations)
* line 1657 -- if ((Gestalt(gestaltSystemVersionMajor, &majorVersion) == noErr) &&
* line 1658 -- (Gestalt(gestaltSystemVersionMinor, &minorVersion) == noErr)) {
/toolkit/xre/nsNativeAppSupportCocoa.mm (View Hg log or Hg annotations)
* line 110 -- OSErr err = ::Gestalt (gestaltSystemVersion, &response);
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #399601 -
Flags: review?(joshmoz)
Attachment #399601 -
Flags: review?(joshmoz) → review+
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/c5fad7d529ec
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•