Closed
Bug 515069
Opened 17 years ago
Closed 17 years ago
Socorro UI: top crash by url expanding rows yields incorrect info
Categories
(Socorro :: General, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lars, Assigned: lars)
Details
Attachments
(1 file, 1 obsolete file)
|
1.32 KB,
patch
|
ozten
:
review+
|
Details | Diff | Splinter Review |
Expanding a row on Top Crashers By URL for Firefox 3.6a1pre yields incorrect results. This is shown on staging by expanding for "about:blank" which should have only a count of 5. The result is 20 rows open with counts of 890 each. The totals look suspicious because they clearly do not sum to 5.
The problem is the SQL in topcrashersbyurl.php that does not take into account the product. I've corrected the sql, and submit this patch for consideration...
Attachment #399089 -
Flags: review?(ozten.bugs)
|
Assignee | |
Comment 1•17 years ago
|
||
2nd try at attaching the right thing...
Attachment #399089 -
Attachment is obsolete: true
Attachment #399096 -
Flags: review?(ozten.bugs)
Attachment #399096 -
Flags: review?(griswolf)
Attachment #399089 -
Flags: review?(ozten.bugs)
|
||
Comment 2•17 years ago
|
||
Lars' patch looks reasonable to me.
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 399096 [details] [diff] [review]
patch for sql in topcrashersbyurl.php fixing SQL
Looks great! Please commit this patch.
Attachment #399096 -
Flags: review?(ozten.bugs) → review+
|
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → lars
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Attachment #399096 -
Flags: review?(griswolf)
|
||
Updated•14 years ago
|
Component: Socorro → General
Product: Webtools → Socorro
You need to log in
before you can comment on or make changes to this bug.
Description
•