Created attachment 399089 [details] [diff] [review] patch for sql in topcrashersbyurl.php fixing SQL Expanding a row on Top Crashers By URL for Firefox 3.6a1pre yields incorrect results. This is shown on staging by expanding for "about:blank" which should have only a count of 5. The result is 20 rows open with counts of 890 each. The totals look suspicious because they clearly do not sum to 5. The problem is the SQL in topcrashersbyurl.php that does not take into account the product. I've corrected the sql, and submit this patch for consideration...
Created attachment 399096 [details] [diff] [review] patch for sql in topcrashersbyurl.php fixing SQL 2nd try at attaching the right thing...
Lars' patch looks reasonable to me.
Comment on attachment 399096 [details] [diff] [review] patch for sql in topcrashersbyurl.php fixing SQL Looks great! Please commit this patch.
Attachment #399096 - Flags: review?(ozten.bugs) → review+
Assignee: nobody → lars
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.