Closed Bug 515177 Opened 11 years ago Closed 11 years ago

call generate-snippets-% from buildbot rather than the build system

Categories

(Release Engineering :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: armenzg)

References

Details

Attachments

(4 files)

In the release 3.5.2 the call from the build system was commented out since the file generatesnippets.py had not landed yet (https://wiki.mozilla.org/Releases/Firefox_3.5.2/BuildNotes#Build.2FRepack)

Since calling generatesnippets.py would really do nothing useful for the release code path (snippets are generated somewhere else) I am removing calling the target from the build system and calling it explicitly from buildbot so the nightly code path does interfere with the release one.
Attachment #399209 - Flags: review?(ccooper)
Attachment #399210 - Flags: review?(ccooper)
Attachment #399210 - Attachment description: remove call to generate-snippet-% target (moz192 and mc) → remove call to generate-snippet-% target (moz191)
Blocks: 512300
Attachment #399209 - Flags: review?(ccooper) → review+
Attachment #399210 - Flags: review?(ccooper) → review+
Attachment #399211 - Flags: review?(ccooper) → review+
I would like to deploy these changes on Monday
Comment on attachment 399211 [details] [diff] [review]
remove call to generate-snippet-% target (moz192 and mc)

1.9.2: changeset:   31686:3cd88d729da1
m-c: changeset:   26356:cbc05cbe8aa2
Attachment #399210 - Flags: checked-in+
Attachment #399211 - Flags: checked-in+
Comment on attachment 399210 [details] [diff] [review]
remove call to generate-snippet-% target (moz191)

1.9.1: changeset:   32456:afcf065f2ff6
Comment on attachment 399209 [details] [diff] [review]
add generate-snippet step to the NightlyRepackFactory if self.createSnippet is on

changeset:   409:06a9e2940afc
Attachment #399209 - Flags: checked-in+
This fixes the l10n repackages for moz1.9.1 since even if generate-snippets-% is defined in l10n.mk but not imported on browser/locales/Makefile.in

This has been run on staging for all 3 branches
Attachment #400801 - Flags: review?(ccooper)
Attachment #400801 - Flags: review?(ccooper) → review+
Attachment #400801 - Flags: checked-in?
Comment on attachment 400801 [details] [diff] [review]
only run createSnippet() when self.createSnippet is on and l10nNightlyUpdate

changeset:   413:b8cb808f0907
Attachment #400801 - Flags: checked-in? → checked-in+
The locales in all 3 branches are green now. Closing FIXED.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.