515177 - call generate-snippets-% from buildbot rather than the build system

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Armen [:armenzg]]

Attachment: add generate-snippet step to the NightlyRepackFactory if self.createSnippet is on

In the release 3.5.2 the call from the build system was commented out since the file generatesnippets.py had not landed yet (https://wiki.mozilla.org/Releases/Firefox_3.5.2/BuildNotes#Build.2FRepack)

Since calling generatesnippets.py would really do nothing useful for the release code path (snippets are generated somewhere else) I am removing calling the target from the build system and calling it explicitly from buildbot so the nightly code path does interfere with the release one.

Comment 1

[Armen [:armenzg]]

Attachment: remove call to generate-snippet-% target (moz191)

Comment 2

[Armen [:armenzg]]

Attachment: remove call to generate-snippet-% target (moz192 and mc)

Comment 3

[Armen [:armenzg]]

I would like to deploy these changes on Monday

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 399211 [details] [diff] [review]
remove call to generate-snippet-% target (moz192 and mc)

1.9.2: changeset:   31686:3cd88d729da1
m-c: changeset:   26356:cbc05cbe8aa2

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 399210 [details] [diff] [review]
remove call to generate-snippet-% target (moz191)

1.9.1: changeset:   32456:afcf065f2ff6

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 399209 [details] [diff] [review]
add generate-snippet step to the NightlyRepackFactory if self.createSnippet is on

changeset:   409:06a9e2940afc

Comment 7

[Armen [:armenzg]]

Attachment: only run createSnippet() when self.createSnippet is on and l10nNightlyUpdate

This fixes the l10n repackages for moz1.9.1 since even if generate-snippets-% is defined in l10n.mk but not imported on browser/locales/Makefile.in

This has been run on staging for all 3 branches

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 400801 [details] [diff] [review]
only run createSnippet() when self.createSnippet is on and l10nNightlyUpdate

changeset:   413:b8cb808f0907

Comment 9

[Armen [:armenzg]]

The locales in all 3 branches are green now. Closing FIXED.