515181 - Pending unsubmitted crash reports don't retain user comments

Status: NEW

(Toolkit :: Crash Reporting, defect)

Description

[Noah (NoahSUMO/SolidSnake) [:Noah]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090824 Firefox/2.0.0.20
Build Identifier: 

I crashed and my report failed to submit for an unknown reason, for something other than no internet connection. Submit.log gave this:
[09/08/09 10:31:51] Crash report submission failed: The system cannot find the file specified.

But the .dmp & .extra bits still remained and were able to be resent thanks to  Bug 378528.

Anyway, in that unsubmitted report, I filled out the user comments section but when resubmitted the crash, didn't see the comments included. I assume the user comments should be added to the *.extra file but wasn't in this case.

This bug is to investigate that.

Reproducible: Always

Comment 1

[Noah (NoahSUMO/SolidSnake) [:Noah]]

Attachment: .extra file from unsubmitted crash

Attaching copy of .extra file

It's missing a field for user comments.

Comment 2

[Arie Paap [:wildmyron]]

Still present on Win XP with nightly built from http://hg.mozilla.org/mozilla-central/rev/31879b88cc82

Comments can not be submitted when behind an authenticated proxy - the crash reporter always fails to submit; there is no comment field in the .extra file and when submitting the report via about:crashes no comment is submitted (obviously)

Comment 3

[Jonathan Watt [:jwatt]]

This bug is still present.

Could this be one of the reasons users so frequently give a comment describing how to reproduce their crash (a huge headache for devs trying to fix our crashes)? Do we have stats on what percentage of crashes are stored as "pending" before being sent?

Comment 4

[(not currently active) Ted Mielczarek]

(In reply to Jonathan Watt [:jwatt] (needinfo? me) from comment #3)
> This bug is still present.
> 
> Could this be one of the reasons users so frequently give a comment
> describing how to reproduce their crash (a huge headache for devs trying to
> fix our crashes)? Do we have stats on what percentage of crashes are stored
> as "pending" before being sent?

We don't have any stats on this, no. I suspect the reality is that very few users write comments in general, but I don't know for sure.

Fixing this would involve making the crashreporter client write the contents of the comment box into the .extra file before submitting.

Comment 5

[Jeronimo Torti (Please send NI request to Brindusa Tot)]

Edit: Please ignore my comment, I'm unable to reproduce the issue. I'm removing the flag. Thanks!