515232 - "distribution" searchplugins dont work for complex general.useragent.locale

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Alexander Sack]

currently the localized searchengines feature for "distribution/searchplugins" is broken for builds that use a complex pref for general.useragent.locale - which is what we don in ubuntu

Also its not possible to overload searchplugins in the "common" directory in the locale folder, which could be fixed by changing the order of the searchplugindirs returned in browser/components/dirprovider/nsBrowserDirectoryProvider.cpp ... which I would like to address in the same patch.

Comment 1

[Alexander Sack]

Attachment: patch 1

Comment 2

[Alexander Sack]

Attachment: patch 1 without garbage

Comment 3

[Alexander Sack]

Attachment: patch 2 - use global chrome registry selectedLocale

Comment 4

[Mike Hommey [:glandium]]

Attachment: Try getting general.useragent.locale as a complex value first in DirectoryProvider.cpp

Only the first paragraph of comment 0 still applies. Instead of using Alex's approach of using chrome registry, I'm just using GetComplexValue, fallbacking to GetChar if that fails, which is what all other code paths getting general.user-agent.locale are using.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 600753 [details] [diff] [review]
Try getting general.useragent.locale as a complex value first in DirectoryProvider.cpp

It might be nice to make this use mozilla::Preferences while we're changing this.

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 600753 [details] [diff] [review]
Try getting general.useragent.locale as a complex value first in DirectoryProvider.cpp

[It's annoying when hg bzexport silently doesn't put the requested review flag for some reason]

Comment 7

[Mike Hommey [:glandium]]

(In reply to Gavin Sharp (use [e-mail] for email) from comment #5)
> Comment on attachment 600753 [details] [diff] [review]
> Try getting general.useragent.locale as a complex value first in
> DirectoryProvider.cpp
> 
> It might be nice to make this use mozilla::Preferences while we're changing
> this.

Unfortunately, mozilla::Preferences is an internal API, and as such is not available from browser.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 600753 [details] [diff] [review]
Try getting general.useragent.locale as a complex value first in DirectoryProvider.cpp

of course - I forgot this was in browsercomps

Comment 9

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5689de2cf0f8

Comment 10

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5689de2cf0f8