515254 - trace-test/tests/sunspider/check-date-format-{tofte|xparb}.js fails due to requirement of PST/PDT TZ

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Comment 1

[Andreas Gal :gal]

We also fail trace-test/tests/sunspider/check-date-format-xparb.js.

Debugging the first failure now. Will file a second bug if its not the same cause.

Comment 2

[Nicholas Nethercote [inactive]]

What's the failure look like?  I'm seeing a problem with these two on x86 that seems related to daylight savings time (all the times are one hour off between March and November), it could be caused by my non-US locale so I'm not sure if I should file that as a separate bug.

Comment 3

[Andreas Gal :gal]

I get the same output for -j and no -j on arm.

Comment 4

[Andreas Gal :gal]

The ARM box was set to CST. Setting the timezone to PST (PDT) and setting the current time properly makes the failure go away. The fact that SS relies on the local time zone setting in a benchmark is an abomination. We should file a bug with Apple.

Comment 5

[Nicholas Nethercote [inactive]]

In the meantime, what do we do about trace-test?  I don't fancy changing my machine's time zones to PDT :(  I can just ignore them, it's annoying but I can live with it.

Comment 6

[Andreas Gal :gal]

I think we will have to live with this for now. I don't want to add TZ-specific hacks to the test.

Comment 7

[Nicholas Nethercote [inactive]]

For those not on the North American west coast, add this:

  -x sunspider/check-date-format-xparb.js -x sunspider/check-date-format-tofte.js

to the trace-tests invocation to skip them.  Obviously this works best in a script or alias.

Comment 8

[Reed Loden [:reed]]

No, the problem is clearly on our end. The actual SunSpider test (http://www2.webkit.org/perf/sunspider-0.9/date-format-tofte.html) does not contain the "expected" line that we have. That's something sayrer (I believe) added specifically for our check-date-format-*.js files.

Ubuntu is attempting to get `make check` done on all builds, so it's bad when tests like this fail just because the build machines are in a different TZ.

Comment 9

[Robert Sayre]

pretty sure jorendorff fixed this

Comment 10

[Reed Loden [:reed]]

(In reply to comment #9)
> pretty sure jorendorff fixed this

When? Ubuntu just ran into this yesterday.

Doesn't look fixed on m-c based on lack of any commits about it in hg log:
http://mxr.mozilla.org/mozilla-central/source/js/src/trace-test/tests/sunspider/check-date-format-tofte.js

Comment 11

[Mike Shaver (:shaver emeritus)]

http://hg.mozilla.org/tracemonkey/rev/4b5938c3b527

Comment 12

[Mike Shaver (:shaver emeritus)]

(The problem is "on our end" to the extent that we check that sunspider produces correct output, which sunspider otherwise cheerfully ignores, and to the extent that sunspider's behaviour varies according to which timezone you're in.)

Comment 13

[Reed Loden [:reed]]

(In reply to comment #11)
> http://hg.mozilla.org/tracemonkey/rev/4b5938c3b527

Cool.

check-date-format-tofte.js needs fixing, too, I believe, as per comment #7.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Looks like check-date-format-tofte.js still needs fixing?
http://mxr.mozilla.org/mozilla-central/source/js/src/jit-test/tests/sunspider/check-date-format-tofte.js#301

Comment 15

[Nicholas Nethercote [inactive]]

I can't reproduce this any more, and I'm in ADST timezone which is a pretty good stress test.