515362 - Links are not followed on first click

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Fabrice Desré]

Steps to reproduce :

1. go to any page that needs bottom panning to show link
2. click on such a link

Instead of following the link, you move up. A second click on the yellow link area works.

This doesn't happen with links that are in the initially visible part of a page.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

I think this is better than dispatching the mousedown (and prevent unpredictable scroll).

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Stuart, I've seen your comment on IRC, so are we supposed to removed the highlighting part or find a way to get rid of the call to bv.renderNow?
(in fact the rendering is pause by the pauseRendering call in dragStart, and the 'focus' event seems to be async)

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(hmm, not sure that's the right bug to have a discussion on that)

Comment 4

[Benjamin Stover (:stechz)]

As discussed on IRC, the problem is that a lot of tiles are invalidated on mousedown right now.  The repaints may be caused by something in content mousedown or simply by focusing the link.  We need to test if Vivien's patch fixes the problem.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 400251 [details] [diff] [review]
Patch

This patch looks ok to me. I'm hoping the removal of the mousedown dispatch so early doesn't affect the "button looks pressed" class of bugs.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Chrome panning is unaffected (as it should be) and the link jumping is fixed

pushed:
https://hg.mozilla.org/mobile-browser/rev/68dcaa32558e

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED (this was definitely a headache on the n810) on build:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090916
Fennec/1.0b4pre