Closed Bug 515530 Opened 12 years ago Closed 9 years ago
HTMLContainer Frame, ns Container Frame to one class
Followup from bug 233463 comment 62 -- From Boris Zbarsky (:bz) 2009-08-25 08:44:30 PDT: For that matter, I'm not quite sure why we have separate nsHTMLContainerFrame and nsContainerFrame, but that's also fodder for a separate bug.
dbaron, roc, is there a point to having these be separate classes?
Status: UNCONFIRMED → NEW
Ever confirmed: true
I don't think so.
There was one issue - both nsHTMLContainerFrame, nsContainerFrame implements BuildDisplayList. Identically, except nsHTMLContainerFrame uses DISPLAY_CHILD_INLINE and nsContainerFrame does not. Investigating all classes that inherit nsHTMLContainerFrame... nsHTMLFramesetFrame nsInlineFrame implements BuildDisplayList that explicitly calls nsHTMLContainerFrame::BuildDisplayList nsProgressFrame nsFirstLetterFrame does not implement BuildDisplayList I made the above four have a BuildDisplayList that calls a new (protected) convenience method BuildDisplayListForInline that implements the DISPLAY_CHILD_INLINE version. The remaining derived classes all implements BuildDisplayList but does not call nsHTMLContainerFrame::BuildDisplayList.
Attachment #584162 - Flags: review?(roc)
Attachment #584162 - Flags: review?(roc) → review+
Target Milestone: --- → mozilla12
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.