515542 - partial updates have no defined size (nightly updates fail integrity check)

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Axel Hecht [:Pike]]

I just received an integrity error trying to upgrade my german mac nightly from Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.2a2pre) Gecko/20090908 Namoroka/3.6a2pre

I get an error in the error console, too:

Fehler: this._update is null
Quelldatei: file:///Applications/Namoroka.app/Contents/MacOS/components/nsUpdateService.js
Zeile: 2586

The full download doesn't complete either.

I didn't see anything suspicious in the pushlog, so filing in releng for now.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

The partial hash is fine but the declared size is "":

<updates>
<update type="minor" version="3.6a2pre" extensionVersion="3.6a2pre" buildID="20090909040930">
<patch type="complete" URL="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/09/2009-09-09-04-mozilla-1.9.2-l10n/firefox-3.6a2pre.de.mac.complete.mar" hashFunction="SHA1" hashValue="e59cdf273ca3f5e30d13554d9d1f48ba62587f34" size="17697655"/>
<patch type="partial" URL="http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/09/2009-09-08-03-mozilla-1.9.2-l10n/firefox-3.6a2pre.de.mac.partial.20090908033627-20090909040930.mar" hashFunction="SHA1" hashValue="712b5c41c857855be64452be98f861d6119277f5" size=""/>
</update>
</updates>

The same is true of lots of snippets from many 20090908 builds. It'll be a regression from bug 515364 or bug 513763.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

321 partial.txt with 'size=' removed from production, including mozilla-1.9.2 windows and mac nightlies for en-US. That should stop breaking nightly users.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

The timestamp on the first broken snippet is 6:56 PDT this morning, corresponding to the first entry in /tmp/20090909.log, so this is definitely from bug 513763. So I've done |cvs up -D "2009/09/09 13:00:00 UTC"| and removed the broken partial.txt's from the aus/ dir. New snippets are being generated now (en-US are up already).

Comment 4

[Axel Hecht [:Pike]]

Thanks, just updated to Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.2a2pre) Gecko/20090909 Namoroka/3.6a2pre.