Closed Bug 515614 Opened 12 years ago Closed 12 years ago

Inconsistent representation of "All" for new autosync_max_age_days preference

Categories

(MailNews Core :: Account Manager, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

Details

Attachments

(1 file)

While bug 482476 specified any value less or equal to zero as "off" switch for the autosync time policy, it is consistently represented as "-1" in both the backend and the mail.server.default.autosync_max_age_days pref. In contrast, the front end introduced by bug 510707 assigns a "0" though if "All" is chosen. While this has no impact on functionality, it is inconsistent.

Assigning "-1" to mail.server.server#.autosync_max_age_days instead would make it unambiguous what the difference between 0 and -1 may be, and as a positive side effect, also removes the user_pref definition for a server if "All" is chosen as it matches the default.
Attached patch Simple patchSplinter Review
I'm flagging this for review in case it is wanted for beta 4. On the other hand, certainly no damage done if it doesn't make it.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #399710 - Flags: superreview?(bienvenu)
Attachment #399710 - Flags: review?(bugzilla)
Comment on attachment 399710 [details] [diff] [review]
Simple patch

If David's happy with this, then I am as well.
Attachment #399710 - Flags: review?(bugzilla) → review+
Comment on attachment 399710 [details] [diff] [review]
Simple patch

seems fine with me.
Attachment #399710 - Flags: superreview?(bienvenu) → superreview+
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Thanks for the reviews. I prematurely flagged this for checkin already but apparently this still needs an approval step, thus removing checkin request.
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Comment on attachment 399710 [details] [diff] [review]
Simple patch

Minor backend change only.
Attachment #399710 - Flags: approval-thunderbird3?
Attachment #399710 - Flags: approval-thunderbird3? → approval-thunderbird3+
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Checked in: http://hg.mozilla.org/comm-central/rev/2badce8110ad
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.