Closed Bug 515614 Opened 12 years ago Closed 12 years ago
Inconsistent representation of "All" for new autosync
_max _age _days preference
While bug 482476 specified any value less or equal to zero as "off" switch for the autosync time policy, it is consistently represented as "-1" in both the backend and the mail.server.default.autosync_max_age_days pref. In contrast, the front end introduced by bug 510707 assigns a "0" though if "All" is chosen. While this has no impact on functionality, it is inconsistent. Assigning "-1" to mail.server.server#.autosync_max_age_days instead would make it unambiguous what the difference between 0 and -1 may be, and as a positive side effect, also removes the user_pref definition for a server if "All" is chosen as it matches the default.
I'm flagging this for review in case it is wanted for beta 4. On the other hand, certainly no damage done if it doesn't make it.
Comment on attachment 399710 [details] [diff] [review] Simple patch If David's happy with this, then I am as well.
Attachment #399710 - Flags: review?(bugzilla) → review+
Comment on attachment 399710 [details] [diff] [review] Simple patch seems fine with me.
Attachment #399710 - Flags: superreview?(bienvenu) → superreview+
Thanks for the reviews. I prematurely flagged this for checkin already but apparently this still needs an approval step, thus removing checkin request.
Comment on attachment 399710 [details] [diff] [review] Simple patch Minor backend change only.
Attachment #399710 - Flags: approval-thunderbird3?
Attachment #399710 - Flags: approval-thunderbird3? → approval-thunderbird3+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [c-n: comm-central]
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.