Closed
Bug 515645
Opened 15 years ago
Closed 15 years ago
Stop stripping mac nightlies
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: coop)
References
Details
Attachments
(1 file)
|
1.98 KB,
patch
|
armenzg
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
We should --disable-install-strip our mac nightlies. That will let us shark them, make the apple crash reporter work (in cases when breakpad doesn't trigger for some reason), and generally make them happier campers.
The claim is that the download size increase here is negligible, which I buy.
|
||
Comment 1•15 years ago
|
||
firefox-3.7a1pre.en-US.mac-shark.dmg 10-Sep-2009 04:22 13M
firefox-3.7a1pre.en-US.mac.dmg 10-Sep-2009 04:08 17M
Hard to directly compare, because the Shark builds aren't universal, but it's just a few more MB, I think.
|
Reporter | |
Comment 2•15 years ago
|
||
fwiw, stripping out ppc stuff from a normal nightly puts it at 10MB or so.
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #0)
> We should --disable-install-strip our mac nightlies.
Nightlies on which branches? m-c only?
|
|
Reporter | |
Comment 4•15 years ago
|
||
At least m-c. I don't know about others.
|
|
||
Comment 5•15 years ago
|
||
We could flip it on all branches. The only difference would be that a) our builds would get larger by a few MB, and b) users would be able to profile their nightly builds with Shark and get good stacks in the Apple Crash Reporter.
|
|
Assignee | |
Comment 6•15 years ago
|
||
I'll put together patches for all branches then.
Assignee: nobody → ccooper
Status: NEW → ASSIGNED
Priority: -- → P2
|
|
Assignee | |
Comment 7•15 years ago
|
||
mozconfigs for other branches are symlinks back to m-c, so we just have to make the change in one place (+mobile).
Attachment #400862 -
Flags: review?(armenzg)
|
||
Updated•15 years ago
|
Attachment #400862 -
Flags: review?(armenzg) → review+
|
|
Assignee | |
Comment 8•15 years ago
|
||
Comment on attachment 400862 [details] [diff] [review]
Add --disable-install-strip option for mac nightlies
http://hg.mozilla.org/build/buildbot-configs/rev/3eb4d72c7834
Attachment #400862 -
Flags: checked-in+
|
|
Assignee | |
Comment 9•15 years ago
|
||
Both production masters have been reconfig-ed with this change. Tomorrow's nightlies should not be stripped.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•