515703 - "ASSERTION: What happened here?" in nsHTMLFormElement::GetDefaultSubmitElement

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

layout/reftests/bugs/352980-3d.html triggers:

###!!! ASSERTION: What happened here?: 'mDefaultSubmitElement == mFirstSubmitInElements || mDefaultSubmitElement == mFirstSubmitNotInElements', file /Users/jruderman/central/content/html/content/src/nsHTMLFormElement.cpp, line 1747

Could this be related to the recent change in bug 513153?

Comment 1

[Boris Zbarsky [:bzbarsky]]

My local build with that change is not showing this bug.

Comment 2

[Boris Zbarsky [:bzbarsky]]

No assertion after updating to tip either.  This is the case with both the normal and the HTML5 parser.  I'm on Mac.  Jesse, are you seeing this on Mac?  If so, what else are you doing that's interesting to trigger it?

Comment 3

[Jesse Ruderman]

Yes, I'm testing on Mac.  I still get it after updating and using a fresh profile.  It asserts with HTML5 parser both on and off.  rev b11f8b61ce71+

So, I don't know what extra thing I'm doing to trigger it :(

Comment 4

[Jesse Ruderman]

Btw, I'm loading the test directly, not as part of the test suite.

Comment 5

[Jesse Ruderman]

Attachment: stack trace

Comment 6

[Boris Zbarsky [:bzbarsky]]

I was testing rev 613cf52be14d, and also loading directly from a file:// url....

Comment 7

[Boris Zbarsky [:bzbarsky]]

So what happens here is that inside a single update we first remove the node from the form and then do the rest of the attribute change, including the IntrinsicState() get when notifying on this stuff.  Since the mFirstSubmitElement doesn't get updated until after the update finishes, we run into this assertion.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: This should do the trick

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Without the bogus comment

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: And without the bogus css changes

Comment 11

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/7830998eef61