515711 - Rewrite rule for es (non en-US locales) includes +1, +2, +3, but should not

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. In Firefox 3.5.2, open about:config and change app.support.baseURL to point to staging (http://support-stage.mozilla.org/1/%APP%/%VERSION%/%OS%/%LOCALE%/)
2. Go to Help, Help Contents (which triggers the F1 rewrite rule)

Expected:

Sent to http://support-stage.mozilla.org/es/kb/Firefox+Help?style_mode=inproduct

Actual:

Sent to http://support-stage.mozilla.org/es/kb/Firefox+Help+1?style_mode=inproduct

According to https://bugzilla.mozilla.org/show_bug.cgi?id=498920#c0, rewrite rules that add +1, +2, +3 are for en-US and 3.5.x ONLY

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This also fixes the post in bug 498920 for other versions of firefox that have -help,-f1,-osxkey links. So, bug 498920 attachment 397736 [details] [diff] [review] is obsolete. We can mark that bug fixed if this lands.

Comment 2

[Laura Thomson :laura]

Comment on attachment 399792 [details] [diff] [review]
patch, v1

keep the ordering the same...otherwise ok.

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1.1

This good?

Comment 4

[Paul Craciunoiu [:paulc]]

r51244 / r51245

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED (phew); tested pretty thoroughly (it would take me a long time to list all I've tested).

Tested both positive and negative cases (3.0.14 en-US, 3.5.3 en-US (+1/+2/+3, etc.), 3.5.3 es (no +1/+2/+3)...

Comment 7

[David Tenser [:djst]]

Just wanted to say thanks, Stephen, for the extensive testing here; really important to get this one right!