515759 - More light-on-dark theme issues

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Issue when a dark background OS theme is used:
* About Firefox page has a dark background
* About Cert Error page has a dark background

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch changes some colors to explicit, changes an em-based margin and resets the fonts in aboutCertError.css and an overridden about.css

Comment 3

[Aakash Desai [:aakashd]]

Putting some more information in for use later.

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090923
Fennec/1.0b4pre

Steps to Reproduce:
1. Go to about: on the n900

Actual Results:
The bgcolor is all black.

Expected Results:
bgcolor should be gray instead.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 402411 [details] [diff] [review]
patch

don't really like overriding about.css (makes it easier for them to get out of sync), but I guess it's kind of unavoidable here.

r=me with s/silver/#f0f0f0/

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with color change:
https://hg.mozilla.org/mobile-browser/rev/aa2e55c8ff2f

Comment 6

[Aakash Desai [:aakashd]]

This is an fugly bug for the n900, but the background has been changed to gray on both:


Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre