Closed Bug 515759 Opened 10 years ago Closed 10 years ago

More light-on-dark theme issues

Categories

(Firefox for Android Graveyard :: General, defect)

x86
macOS
defect
Not set

Tracking

(fennec1.0+)

VERIFIED FIXED
fennec1.0b4
Tracking Status
fennec 1.0+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(1 file)

Issue when a dark background OS theme is used:
* About Firefox page has a dark background
* About Cert Error page has a dark background
tracking-fennec: --- → ?
tracking-fennec: ? → 1.0+
Assignee: nobody → mark.finkle
Duplicate of this bug: 518373
Attached patch patchSplinter Review
This patch changes some colors to explicit, changes an em-based margin and resets the fonts in aboutCertError.css and an overridden about.css
Attachment #402411 - Flags: review?(gavin.sharp)
Putting some more information in for use later.

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090923
Fennec/1.0b4pre

Steps to Reproduce:
1. Go to about: on the n900

Actual Results:
The bgcolor is all black.

Expected Results:
bgcolor should be gray instead.
Comment on attachment 402411 [details] [diff] [review]
patch

don't really like overriding about.css (makes it easier for them to get out of sync), but I guess it's kind of unavoidable here.

r=me with s/silver/#f0f0f0/
Attachment #402411 - Flags: review?(gavin.sharp) → review+
pushed with color change:
https://hg.mozilla.org/mobile-browser/rev/aa2e55c8ff2f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4
This is an fugly bug for the n900, but the background has been changed to gray on both:


Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.