515855 - Gloda depends on chrome://messenger/ string-bundle, breaks in seamonkey

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

The recent changes for bug 474711 to provide a faceted search interface exposed gloda to the UI in a non-under-the-hood fashion for the first time.  This necessitated the introduction of support for localized strings in gloda.

The string bundle is currently found at:
  chrome://messenger/locale/gloda.properties

The keys in the bundle are based on a hierarchical naming convention that the
generic parts of gloda understand and use to surface strings into attributes
(and some day, nouns).

There are two possible courses of action:

1) Add an empty gloda.properties file to SeaMonkey's messenger namespace.

2) Disable building/installing gloda in non-Thunderbird builds.  My rationale is mainly that until SeaMonkey actually ships some UI that depends on gloda it probably shouldn't ship gloda.  Without default UI, that just leaves extensions, and I think that would end up being a versioning nightmare for all parties involved.  Since gloda has done little to deviate from its extension history, I think the SeaMonkey extension community would do better to hoist gloda back out into an extension so they could have something that tracks Thunderbird's stable releases of gloda.

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> There are two possible courses of action:
> 
> 1) Add an empty gloda.properties file to SeaMonkey's messenger namespace.

I tried this, but the gloda tests still fail. It has to be a copy of Thunderbird's file - i.e. include the strings as well.

> 2) Disable building/installing gloda in non-Thunderbird builds.

That sounds like a reasonable possibility.

Comment 2

[[e-mail]]

(In reply to comment #0)
> The recent changes for bug 474711
Is that the right bug#? I don't actually see a mention of chrome://messenger/locale/gloda.properties there.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(In reply to comment #2)
> (In reply to comment #0)
> > The recent changes for bug 474711
> Is that the right bug#? I don't actually see a mention of
> chrome://messenger/locale/gloda.properties there.

http://hg.mozilla.org/comm-central/log/fa1a67b49a3c/mail/locales/en-US/chrome/messenger/gloda.properties

Comment 4

[[e-mail]]

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #0)
> > > The recent changes for bug 474711
> > Is that the right bug#? I don't actually see a mention of
> > chrome://messenger/locale/gloda.properties there.
> http://hg.mozilla.org/comm-central/log/fa1a67b49a3c/mail/locales/en-US/chrome/messenger/gloda.properties
But still no bug# mentioned...

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

(In reply to comment #4)
> But still no bug# mentioned...

The development was performed as part of bug 474711.

We did the development on task branches using pbranch.  It was determined that it was preferable to merge the branches down rather than collapsing all of the version history into a single commit which would have our standard commit messages.  If you follow the branch history to the default branch, you will see a message with the bug number referenced.

Perhaps next time we should pass the revisions through a filtering step to tag each commit message more obviously.

Comment 6

[Robert Kaiser]

I'd like to have gloda shipped in SeaMonkey in a state that an extension can use it, e.g. even an extensions that implements the faceting UI.
So if the shared backend needs strings, we should ship them in SeaMonkey, even if we don't use them right now. Given that localizers who do a SeaMonkey L10n all have a Thunderbird L10n as well, it's not much more work for them. :)

Not blocking release on something not visible to normal users, but wanted for that fact of enabling extensions to make use of gloda.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Copy gloda.properties "as is" from Thunderbird

Like this?

Comment 8

[[e-mail]]

Well, in order that it matches the rest of our UI, I'd prefer if all references to "star" could be restored to "flag" (including rewriting the localisation note too, I guess), and could you also remove the "To" after "Replied"?

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Copy gloda.properties from Thunderbird, Update it for SeaMonkey [Checkin: See comment 11+13]

Av1, with comment 8 suggestion(s).

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 402584 [details] [diff] [review]
(Av2) Copy gloda.properties from Thunderbird, Update it for SeaMonkey
[Checkin: See comment 11+13]

I don't think I'm the right reviewer for this for mail/; don't know who is? sipaq?.  Good catch on the error in the localization note, though.

And I definitely am not an appropriate reviewer for SeaMonkey...

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 402584 [details] [diff] [review]
(Av2) Copy gloda.properties from Thunderbird, Update it for SeaMonkey
[Checkin: See comment 11+13]


http://hg.mozilla.org/comm-central/rev/6d6ca335bf56
SeaMonkey part only

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #11)
> http://hg.mozilla.org/comm-central/rev/6d6ca335bf56

verified-seamonkey2.0, per tinderboxes.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 402584 [details] [diff] [review]
(Av2) Copy gloda.properties from Thunderbird, Update it for SeaMonkey
[Checkin: See comment 11+13]


http://hg.mozilla.org/comm-central/rev/b21aeef2a21a
Thunderbird part only