51588 - 'Edit' and 'Remove' buttons should appear disabled in Helper apps window when no app is chosen

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[shrirang khanzode]

Build:2000090606m18, all plfs

Steps:

1 Go to Edit|Preferences
2 Click on Helper Applications under Navigator
3 Observe that the 'Edit' and 'Remove' buttons appear active even when the mouse 
focus is not on any of the helper applications.


Expected: Mozilla should behave same as 4.x where these two buttons appear 
disabled unless any application is explicitely highlighted.

Comment 1

[shrirang khanzode]

qa: shri

Comment 2

[Viswanath Ramachandran]

nav triage: not a netscape beta stopper.

Comment 3

[Boris Zbarsky [:bzbarsky]]

updating severity and keywords

Comment 4

[Keyser Sose]

Attachment: Patch to fix problem

Comment 5

[Keyser Sose]

Attachment: Patch 2 (fix for style issue)

Comment 6

[Boris Zbarsky [:bzbarsky]]

r=bzbarsky for patch2.  Looks right and works when I try it.

Alec, could you sr?

Comment 7

[Alec Flett]

shouldn't we be using .disabled? I'll let timeless or blake answer that one for
sure... I'll defer to them on which one we should be using, and then sr=alecf on
that method.

Comment 8

[Boris Zbarsky [:bzbarsky]]

That file uses setAttribute elsewhere when it disables those buttons.. so if we
decide to use .disabled, we should fix it throughout the file.

Comment 9

[timeless]

yeah, we're moving to .disabled, please use it locally, or fix the file 
globally.
fwiw, .removeAttribute("disabled") => .disabled=false

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch using .disabled instead

Comment 11

[timeless]

r=timeless

Comment 12

[Alec Flett]

(just to reiterate, this now gets an automatic sr=alecf)

Comment 13

[timeless]

fix checked in

Comment 14

[shrirang khanzode]

verified on all 03/13 trunk builds.