Closed Bug 51591 Opened 25 years ago Closed 25 years ago

changing a list style results in entire list getting selected

Categories

(Core :: DOM: Editor, defect, P4)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: sujay, Assigned: mozeditor)

References

Details

using 9/6 build 1) launch netscape 2) launch composer 3) click on bullet list 4) enter several items 5) click on middle of list somewhere 6) bring up Format | List properties 7) change list to numbered list notice it does change to numbered list BUT it highlights the entire list. It shouldn't do that. all platforms.
assigning to jfrancis for starters
Assignee: beppe → jfrancis
Severity: normal → trivial
Priority: P3 → P4
Target Milestone: --- → M19
i bet charlie fixed the other bug about using the list menu getting the whole list to change (instead of just one item), and i bet he did it from javascript, and thus didnt have a way to save/restore the selection since I haven't yet given him the tools (see bug 44012). am I guessing right charlie? I'm assigning this to charlie - it should be trivial for him to fix it once I fix 44012. Marking this dependent on 44012.
Assignee: jfrancis → cmanske
Depends on: 44012
As I explained in bug 45407, selecting the list is the only way to implement what was requested in that bug: to change the list type of all items in the list. Joe's bug 44012 would fix the problem (we could preserve the selection and restore it after changing list type), but that bug is futured, so unless that is fixed, this should be futured as well.
If you want I could add a parameter to MakeList() that allowed us to specify whether to act on the selected list items, or the whole list (as implied by the selection). That way Charlie wouldn't need to save/restore selection.
I thought about doing that as well, but tracing through the code seemed to reveal that you would have to add another parameter to basic rules methods to propagate the param into the correct code. But if you think that's easier than fixing 44012, then go for it.
The basic request is to restore the original selection. Joe's suggestion of passing in a new param to MakeOrChangeList is a good one and relativley easy to do.
Assignee: cmanske → jfrancis
fixed. didnt realize this wasnt b3+ until it was already done.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
verified in 9/29 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.