516056 - Favicon can go to a pressed state in awesome bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build ID:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090911 Fennec/1.0a3

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090911
Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090911
Fennec/1.0b4pre


Steps to Reproduce:
1. Click on the url bar to open the awesome bar.
2. Click on the favicon.
3. Click on the favicon again.

Actual Results:
The favicon has no actions associated with it, but can be in a pressed state.

Expected Results:
The favicon should not have a pressed state when it doesn't have any real action associated with it in that situation.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Perhaps it should dismiss the awesomebar

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Perhaps it should dismiss the awesomebar

In Firefox the awesomebar results are dismissed and larry is shown (that's what it'll happen actually if we dismiss the awesomebar)

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This can also happened when we launch any dialog, as for example the edit bookmark throw through the star on right panel + edit.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 400269 [details] [diff] [review]
Patch

Technically, we could have more than one open dialog. Also, let's just call dialog.close();

Like this:

while (BrowserUI.activeDialog) 
  BrowserUI.activeDialog.close();

?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

(In reply to comment #4)
> (From update of attachment 400269 [details] [diff] [review])
> Technically, we could have more than one open dialog. Also, let's just call
> dialog.close();

Obviously. I'm not sure why i've not thought of that :/

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/d96fca76b037

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090915 Fennec/1.0a3

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090915
Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090915
Fennec/1.0b4pre

Comment 8

[Aakash Desai [:aakashd]]

This is something for our BFTs in the awesome bar section.

Comment 9

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=11561 created to regression test this bug.