The default bug view has changed. See this FAQ.

no handlers listed in Tools->Options->Applications

RESOLVED FIXED in mozilla1.9.3a1

Status

Core Graveyard
File Handling
RESOLVED FIXED
8 years ago
9 months ago

People

(Reporter: Rich Walsh, Assigned: Rich Walsh)

Tracking

Trunk
mozilla1.9.3a1
x86
OS/2

Firefox Tracking Flags

(status1.9.2 .1-fixed, status1.9.1 .8-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 400229 [details] [diff] [review]
fixes bug in GetFromTypeAndExtension()
[Checkin: Comment 1 & 4]

With certain plugins installed, the list of MIME types & handlers in Firefox's Options->Applications dialog is empty.  The cause is a coding error in nsExternalHelperAppService::GetFromTypeAndExtension().

This method should always return NS_OK unless the call to its parent class's method fails.  However in some circumstances, the variable containing this result ('rv') may get changed by the failure of another non-critical call.  When the method returns this spurious error, the calling code aborts its attempt to list the handlers.

With the attached patch installed, the method explicitly returns NS_OK where appropriate.

FYI... once the code is fixed, the listing will include a few MIME types supported by the GBM & mplayer plugins (e.g. GIF & OGG).  These are the entries that triggered the bug.
Attachment #400229 - Flags: review?(mozilla)

Updated

8 years ago
Attachment #400229 - Flags: review?(mozilla) → review+

Comment 1

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b338c37ecb00

Should this go onto the 1.9.2 branch, too? How about 1.9.1?
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 2

8 years ago
Well applying Rich's patch on Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.1.4pre) Gecko/20090925 SeaMonkey/2.0pre fixed the empty handlers in applications. Much nicer application page too.
The patch applied cleanly on the above.

Comment 3

7 years ago
(In reply to comment #1)

> Should this go onto the 1.9.2 branch, too? How about 1.9.1?
Yes, please.
Keywords: checkin-needed
Whiteboard: 1.9.1 and 1.9.2 a=NPOTB only in an OS/2 file
Attachment #400229 - Attachment description: fixes bug in GetFromTypeAndExtension() → fixes bug in GetFromTypeAndExtension() [Checkin: Comment 1 & 4]
Comment on attachment 400229 [details] [diff] [review]
fixes bug in GetFromTypeAndExtension()
[Checkin: Comment 1 & 4]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/66470208b6a6

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d17ee097dc09
status1.9.1: --- → .8-fixed
status1.9.2: --- → .1-fixed
Keywords: checkin-needed
Whiteboard: 1.9.1 and 1.9.2 a=NPOTB only in an OS/2 file
Target Milestone: --- → mozilla1.9.3a1
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.