Closed
Bug 516200
Opened 16 years ago
Closed 16 years ago
Combine nsICSSParser with CSSParserImpl
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 523496
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(1 file)
|
193.22 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #400321 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 2•16 years ago
|
||
This doesn't quite work, I think it leaks
|
||
Comment 3•16 years ago
|
||
Also it'd be nice if we didn't have to add so many exports. You could keep the existing class split but devirtualize the entry points in ns[I]CSSParser and have them downcast themselves to CSSParserImpl on call.
Comment on attachment 400321 [details] [diff] [review]
Patch
Clearing review request given comment 2 (or did you want me to look at it anyway?). (Sorry, should have asked that ages ago.)
How much of this is subsumed by the work in bug 523496?
Attachment #400321 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 5•16 years ago
|
||
I think Zack pretty much did what I was trying to do.
|
|
||
Comment 6•16 years ago
|
||
nsCSSParser no longer exists as an exposed class after the second patch in bug 523496, so... yeah.
|
||
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•