Closed
Bug 516311
Opened 15 years ago
Closed 15 years ago
Disable decode-on-draw and discarding until we can figure out what's going on with perf
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
1.78 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
switching off both discarding and decode-on-draw seems to make the perf regression on mac go away. we should do that for now so that we can leave the new architecture on trunk but give ourselves time to figure out what's going on.
Assignee | ||
Comment 1•15 years ago
|
||
added a patch. flagging joe for review.
Attachment #400412 -
Flags: review?(joe)
Updated•15 years ago
|
Attachment #400412 -
Flags: review?(joe) → review+
Assignee | ||
Comment 2•15 years ago
|
||
pushed to mc in f34cc41267d8. resolving fixed.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 3•15 years ago
|
||
bholley: the checkin appears to have caused this test failure on all three platforms: > test_bug435296.html | image should not be decoded Logs: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1252891384.1252896862.27520.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1252891383.1252896759.26485.gz http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1252891383.1252896940.28221.gz You should probably back out or push some sort of bustage fix (maybe the test should be disabled?)
Assignee | ||
Comment 4•15 years ago
|
||
yeah, I accidentally disabled the wrong test. Switched them around and pushed the bustage fix as 912c6ae3b70c.
You need to log in
before you can comment on or make changes to this bug.
Description
•