516439 - change details link does not show the customizations

Status: RESOLVED FIXED

(Websites Graveyard :: byob.mozilla.com, defect, P1)

Description

[Carsten Book [:Tomcat]]

Steps to reproduce:
-> Generate a new browser, do some customizations etc
-> Click later on the "change details link"
-> Status window say : 

Current browser customizations
*      None yet.

which is wrong :)

Comment 1

[Les Orchard [:lorchard]]

Hmm, currently, the "None yet" means changes with respect to the last saved set of customizations.  So, if you build a browser, then go back and change the locales, it'll only say "Locale"

Maybe this should be changed to list all the active customizations with respect to a plain vanilla browser.

Of course, the email kicking off BYOB again says "would be great for admins/editors to have a link to a summary page of customizations", which is a different bug altogether.  Should probably file one for that, which would be much bigger in scope than just changing the bullet list on the right of the wizard.

Comment 2

[Les Orchard [:lorchard]]

Filed bug 545415 to account for scope beyond simple fix to wizard sidebar

Comment 3

[Les Orchard [:lorchard]]

Pushing into my bug queue.

Comment 4

[Les Orchard [:lorchard]]

Actually, I'm not sure that changing this to list all sections customized ever in the sidebar is the best thing here.  Eventually, it would just be a list of all the sections and not be very useful.  I think the original intent was to indicate changes since the last visit to the wizard.

So, with that in mind, I just checked in r63133 that rephrases the title to "Sections changed this session".  Hopefully that makes more sense.

For a more detailed summary of customizations, non-admins see this when they click "Save and Review". And, after changes for bug 545415, admins / editors can view the complete raw repack definition.