516465 - Adaptive results aren't filtered

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P2)

Description

[Ed Lee :Mardak]

The adaptive query needs to use AUTOCOMPLETE_MATCH where before we post-processed results and the function handled adaptive results the same way as regular searches.

Comment 1

[Marco Bonardo [:mak]]

this could be blocking, i mean, it's a privacy concern. what do you think?

Comment 2

[Ed Lee :Mardak]

Yeah, if a user switches to just History, some adaptive bookmarks could be shown.

Comment 3

[Dietrich Ayala (:dietrich)]

assigning to sdwilsh for now, since it's an async location bar regression.

Comment 4

[Shawn Wilsher :sdwilsh]

We'd need to re-run the adaptive query with the less restrictive match behavior when we have the behavior MATCH_BOUNDARY_ANYWHERE, right?

Comment 5

[Ed Lee :Mardak]

I suppose that's undefined and could go either way. But if it's re-running queries, it's going through the whole history anyway. Might be strange to have adaptive boundary, history boundary, adaptive anywhere, history anywhere results..

Well, the user doesn't really know what type of result it is anyway.

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> Yeah, if a user switches to just History, some adaptive bookmarks could be
> shown.
What we really want to check is that we don't show the star, right?

Comment 7

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 8

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Now with more cowbell^H^H^H^H^H^H^Hcontext

Comment 9

[Dietrich Ayala (:dietrich)]

Comment on attachment 403327 [details] [diff] [review]
v1.0

looks ok, r=me

> /**
>  * Test adapative autocomplete
>  */
> function run_test() {
>   do_test_pending();
>   (tests.shift())();

can you fix that while you're in that file?

Comment 10

[Shawn Wilsher :sdwilsh]

(In reply to comment #9)
> can you fix that while you're in that file?
Don't really know what you are asking for here.  Elaborate?

Comment 11

[Dietrich Ayala (:dietrich)]

(In reply to comment #10)
> (In reply to comment #9)
> > can you fix that while you're in that file?
> Don't really know what you are asking for here.  Elaborate?

in the comment: "adapative"

Comment 12

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

per review comments.

Comment 13

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/8fd2f36796b0

Comment 14

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/aa939b6c9e48