Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove the browser.display.base_font_scaler preference and backend code that processes it

RESOLVED FIXED in mozilla8

Status

()

Core
Layout: Text
--
minor
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Javi Rueda)

Tracking

Trunk
mozilla8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

Blame goes back to 1998 on it (looks like NS4 pref compatibility goo), it's apparently never had any in-tree users, we have better ways of scaling display than the blunt tool of scaling all font display as the preference does.  Also, we'd be able to get rid of some font-scaling code and complexity.
Whiteboard: [good first bug]

Comment 1

8 years ago
Assigning to Maxim, per his request.
Assignee: nobody → thesilversurfer
(Assignee)

Comment 2

6 years ago
The preference not even exist in any file. Some try to read it, but it is not in all.js.

Comment 3

6 years ago
Nothing requires preferences to be in all.js.  Preferences that aren't in all.js can be set, and then code reading them will get the value that was set.
(Assignee)

Comment 4

6 years ago
Seeking for "browser.display.base_font_scaler" in all tress gives me as a result either 1 file found either zero results. The only result found is calling a GetIntPref function, so, when is this value set?

Comment 5

6 years ago
Anyone can set it.  Just open about:config and add a value for this preference.
(Assignee)

Comment 6

6 years ago
(In reply to comment #5)
> Anyone can set it.  Just open about:config and add a value for this
> preference.

Sorry, now I was able to try it. Yeah, setting the pref manually makes the fonts displayed scaled by this value. As you could imagine I am a newbie here, althought I knew about this way to set preferences, this world is new to me. So, thank you for the patience.

I have prepared a patch. It removes the code that reads this value, the line of code that makes public this value to the rest of the source-code and, finally, modifies the functions that takes into count this scale value. I am going to post it now.
(Assignee)

Comment 7

6 years ago
Created attachment 545109 [details] [diff] [review]
patch to the bug 516547
Attachment #545109 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #545109 - Flags: review? → review?(bzbarsky)

Comment 8

6 years ago
Comment on attachment 545109 [details] [diff] [review]
patch to the bug 516547

r=me.

dbaron, can you give this a quick sr?
Attachment #545109 - Flags: superreview?(dbaron)
Attachment #545109 - Flags: review?(bzbarsky)
Attachment #545109 - Flags: review+
Comment on attachment 545109 [details] [diff] [review]
patch to the bug 516547

sr=dbaron
Attachment #545109 - Flags: superreview?(dbaron) → superreview+

Updated

6 years ago
Assignee: thesilversurfer → leofigueres

Comment 10

6 years ago
Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/6be6854338bd
Flags: in-testsuite-
Target Milestone: --- → mozilla8
Merged:
http://hg.mozilla.org/mozilla-central/rev/6be6854338bd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.