Closed Bug 516547 Opened 15 years ago Closed 13 years ago

Remove the browser.display.base_font_scaler preference and backend code that processes it


(Core :: Layout: Text and Fonts, defect)

Not set





(Reporter: Waldo, Assigned: javirid)


(Whiteboard: [good first bug])


(1 file)

Blame goes back to 1998 on it (looks like NS4 pref compatibility goo), it's apparently never had any in-tree users, we have better ways of scaling display than the blunt tool of scaling all font display as the preference does.  Also, we'd be able to get rid of some font-scaling code and complexity.
Whiteboard: [good first bug]
Assigning to Maxim, per his request.
Assignee: nobody → thesilversurfer
The preference not even exist in any file. Some try to read it, but it is not in all.js.
Nothing requires preferences to be in all.js.  Preferences that aren't in all.js can be set, and then code reading them will get the value that was set.
Seeking for "browser.display.base_font_scaler" in all tress gives me as a result either 1 file found either zero results. The only result found is calling a GetIntPref function, so, when is this value set?
Anyone can set it.  Just open about:config and add a value for this preference.
(In reply to comment #5)
> Anyone can set it.  Just open about:config and add a value for this
> preference.

Sorry, now I was able to try it. Yeah, setting the pref manually makes the fonts displayed scaled by this value. As you could imagine I am a newbie here, althought I knew about this way to set preferences, this world is new to me. So, thank you for the patience.

I have prepared a patch. It removes the code that reads this value, the line of code that makes public this value to the rest of the source-code and, finally, modifies the functions that takes into count this scale value. I am going to post it now.
Attachment #545109 - Flags: review?
Attachment #545109 - Flags: review? → review?(bzbarsky)
Comment on attachment 545109 [details] [diff] [review]
patch to the bug 516547


dbaron, can you give this a quick sr?
Attachment #545109 - Flags: superreview?(dbaron)
Attachment #545109 - Flags: review?(bzbarsky)
Attachment #545109 - Flags: review+
Comment on attachment 545109 [details] [diff] [review]
patch to the bug 516547

Attachment #545109 - Flags: superreview?(dbaron) → superreview+
Assignee: thesilversurfer → leofigueres
Flags: in-testsuite-
Target Milestone: --- → mozilla8
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.