jetpack.selection appears to be broken

RESOLVED FIXED in 0.6

Status

Mozilla Labs
Jetpack Prototype
P1
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: aza, Assigned: Mardak)

Tracking

unspecified
x86
All

Details

(Reporter)

Description

8 years ago
with the new 0.5 version of Jetpack, my own dictcc-slidebar (based on
the Wikipedia Slidebar) stopped working correctly.

Something with the selection of text on a webpage broke, because the
selection text isn't brought over to the iframe holding the mobile
version of dict.cc anymore.

Here's the code which works fine for Jetpack 0.4:

-----------------------------------------------------

jetpack.future.import("selection");
jetpack.future.import("slideBar");

jetpack.slideBar.append({
       icon: "http://www.dict.cc/favicon.ico",

       width: 300,

       persist: true,

       html: '<style>scrollbar * {display: none !important;}</style><iframe
class="frame" height="99%" width="100%"
src="http://pocket.dict.cc/?s="></iframe>',

       onReady: function(slide) {
               jetpack.selection.onSelection(function() {
                       $(".frame", slide.contentDocument).attr("src",
"http://pocket.dict.cc/?s=" + jetpack.selection.text);
               });
       }
});

-----------------------------------------------------

I had a look at the respective selection JEP and I'm currently stumped
for where the error lies. Any hints are appreciated!

Comment 1

8 years ago
I'm the person originally reporting the bug, the text is from me. If I can provide more info or anything (besides patches and stuff, I can't really code), feel free to comment here and let me know.

Comment 2

8 years ago
Err,

I may have accidentally changed the e-mail settings for this bug. Just wanted to INCLUDE me since the list at the top said EXCLUDED and now, if I am not mistaken, the people who were INCLUDED are EXCLUDED?

Sorry if I messed things up.
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/labs/jetpack/rev/6d85a2fe7053
Seems like securable membranes doesn't allow giving setTimeout a function provided by the feature, so wrap it with a local function.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: 0.5 → 0.6
You need to log in before you can comment on or make changes to this bug.