516681 - Lightning disables SeaMonkey's throbber

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, defect)

Description

[[e-mail]]

Bug #323952 made Calendar frob the disabled attribute on its throbber, or on whichever app Lightning was installed into. I don't see why this is necessary; Calendar's throbber looks as if it doesn't need to be disabled; Thunderbird's throbber should stay disabled, while SeaMonkey's wants to stay enabled.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Comment on attachment 400741 [details] [diff] [review]
Proposed patch

Trying alternative reviewer.

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 400741 [details] [diff] [review]
Proposed patch

r=mschroeder, but shouldn't the second argument be a string ("true", "false") instead of boolean?

Comment 4

[[e-mail]]

(In reply to comment #3)
> (From update of attachment 400741 [details] [diff] [review])
> r=mschroeder, but shouldn't the second argument be a string ("true", "false")
> instead of boolean?
1. Hey, I'm removing the lines here, so it's not my fault!
2. XPConnect will convert the argument into a string. (The XPConnect conversion is fairly obvious; it's the same as String(x) unless x is null.)

Comment 5

[Martin Schröder [:mschroeder]]

(In reply to comment #4)
> 1. Hey, I'm removing the lines here, so it's not my fault!

Sorry, Neil! It just jumped out at me... didn't think about that you just remove lines.

> 2. XPConnect will convert the argument into a string. (The XPConnect conversion
> is fairly obvious; it's the same as String(x) unless x is null.)

Didn't know of the internals of the conversion, just looked at the idl for elements. :)

Comment 6

[[e-mail]]

Pushed changeset fa851e18cf8e to comm-central.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".