516708 - The meaning of font-size: smaller; has changed

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[[e-mail]]

The meaning of font-size: smaller; has changed some time since Gecko 1.9a4; it used to mean the same as font-size: 83.3333% but now it picks a size from an internal table. However this means that the Modern UI differs from 1.x releases.

The meaning of font-size: larger; has also changed, as far as I can tell it used to mean font-size: 133.3333% so this patch fixes that too.

Comment 1

[[e-mail]]

Attachment: Proposed patch

I'm not too fussed about the larger size changes so if you think they're wrong or should be changed to a different value then let me know.

Comment 2

[Ian Neal]

(In reply to comment #1)
> Created an attachment (id=400761) [details]
> Proposed patch
> 
> I'm not too fussed about the larger size changes so if you think they're wrong
> or should be changed to a different value then let me know.

Any reason why:
/suite/themes/modern/global/console/console.css
/suite/themes/modern/global/customizeToolbar.css
have been missed out for the larger changes?

Comment 3

[[e-mail]]

(In reply to comment #2)
> Any reason why:
> /suite/themes/modern/global/console/console.css
> /suite/themes/modern/global/customizeToolbar.css
> have been missed out for the larger changes?
Oversight on my part, sorry.

Interestingly EditorDialog.css has the rule
.larger {
  font-size: 120%;
}

Comment 4

[Ian Neal]

(In reply to comment #3)
> (In reply to comment #2)
> > Any reason why:
> > /suite/themes/modern/global/console/console.css
> > /suite/themes/modern/global/customizeToolbar.css
> > have been missed out for the larger changes?
> Oversight on my part, sorry.
> 
> Interestingly EditorDialog.css has the rule
> .larger {
>   font-size: 120%;
> }
Yes, I'd be happier with 120% as then the ratio is constant 0.8333333:1 = 1:1.2

Comment 5

[Ian Neal]

Comment on attachment 400761 [details] [diff] [review]
Proposed patch

r=me with additional files and font-size for larger being 120%

Comment 6

[[e-mail]]

Attachment: Updated for review comments

Comment 7

[[e-mail]]

Pushed changeset 9949fa923281 to comm-central.