Closed
Bug 51679
Opened 24 years ago
Closed 22 years ago
Call to SetCookieString needs to pass in an nsIPrompt
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: morse, Assigned: serhunt)
Details
Attachments
(1 file, 3 obsolete files)
2.38 KB,
patch
|
Details | Diff | Splinter Review |
If the prefs are set to warn-before-accepting-cookie, then a cookie nag box will appear when the SetCookieString routine is invoked. This nag box needs to have a parent window in to behave properly as a modal dialog. To determine the parent window, a new parameter has been added to the SetCookieString routine. Temporarily a value of nsnull is being passed in as that parameter. This needs to be changed to be the nsHTMLDocument of the current browser window.
Reporter | ||
Comment 1•24 years ago
|
||
Forget to mention that the call I'm referring to is on line 3408 in mozilla/modules/plugin/nglsrc/nsPluginHostImpl.cpp
Comment 3•24 years ago
|
||
Not a Netscape 6 RTM blocker. FUTURE. This bug has been marked Future because the Netscape engineer it is assigned to is overburdened.
Target Milestone: --- → Future
Comment 4•22 years ago
|
||
Does the following fragment is a correct way to get nsIPrompt? nsCOMPtr<nsIPrompt> prompt; nsCOMPtr<nsIWindowWatcher> wwatch(do_GetService("@mozilla.org/embedcomp/window-watcher;1")); if (wwatch) wwatch->GetNewPrompter(0, getter_AddRefs(prompt));
Comment 5•22 years ago
|
||
pass nsIPrompt to SetCookieString. Also moved getting nsIPrompt to separate function.
Comment 6•22 years ago
|
||
pass nsIPrompt to SetCookieString. Also moved getting nsIPrompt to separate function.
Comment 7•22 years ago
|
||
pass nsIPrompt to SetCookieString. Also moved getting nsIPrompt to separate function.
Comment 8•22 years ago
|
||
pass nsIPrompt to SetCookieString. Also moved getting nsIPrompt to separate function.
Updated•22 years ago
|
Attachment #71462 -
Attachment is obsolete: true
Updated•22 years ago
|
Attachment #71464 -
Attachment is obsolete: true
Updated•22 years ago
|
Attachment #71465 -
Attachment is obsolete: true
Comment 9•22 years ago
|
||
Oops, too many patches, sorry :-) Changing summary: s/nsHTMLDocument/nsIPrompt/, as now SetCookieString() needs prompt, not document
Comment 10•22 years ago
|
||
removing myself from cc:
Comment 11•22 years ago
|
||
this is already fixed, serge implemented the change in another fix - see bug 44169
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•