Closed
Bug 516848
Opened 15 years ago
Closed 15 years ago
GetTotalHeapSize broken, doesn't take into account numDecommitted
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: treilly, Assigned: treilly)
References
Details
Attachments
(1 file)
|
349 bytes,
patch
|
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•15 years ago
|
||
This makes it so that the kMemSoftHeapLimit -> kMemNormal never happens.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #400920 -
Flags: superreview?(lhansen)
|
||
Updated•15 years ago
|
Attachment #400920 -
Flags: superreview?(lhansen) → superreview+
|
|
Assignee | |
Comment 2•15 years ago
|
||
I did some digging and submitted a better fix:
changeset: 2506:2152b7891522
tag: tip
user: Tommy Reilly <treilly@adobe.com>
date: Wed Sep 16 08:15:57 2009 -0400
files: MMgc/GCHeap.cpp MMgc/GCHeap.h
description:
Return GetTotalHeapSize, a year ago I changed it to calculate this
from the Regions b/c the MIR JIT stored memory in regions that wasn't
represented in blocksLen but that code was removed so restore this.
This new code was busted b/c it didn't take into account
numDecommitted.
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•