Closed
Bug 516882
Opened 15 years ago
Closed 15 years ago
Lightning needs UI/CSS tweaks for SeaMonkey.
Categories
(SeaMonkey :: MailNews: General, defect)
SeaMonkey
MailNews: General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0
People
(Reporter: philip.chee, Assigned: iannbugzilla)
References
Details
(Keywords: fixed-seamonkey2.0)
Attachments
(1 file, 2 obsolete files)
988 bytes,
patch
|
neil
:
review+
neil
:
superreview+
kairo
:
approval-seamonkey2.0+
|
Details | Diff | Splinter Review |
From Bug 516453 Comment 12:
>>diff --git a/suite/mailnews/messenger.css b/suite/mailnews/messenger.css
>>diff --git a/suite/mailnews/preferences.xul b/suite/mailnews/preferences.xul
> I still don't like those two bits living in SeaMonkey instead of Lightning, as
> they're now both fast hacks on our side for something that should be done
> cleaner and in Lightning itself in the future
Reporter | ||
Updated•15 years ago
|
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•15 years ago
|
||
SeaMonkey doesn't need this menu item in the New Message popup since it already has it's own menu items there. I hope I've chosen a suitable reviewer.
Attachment #401024 -
Flags: review?(philipp)
(In reply to comment #1)
> Created an attachment (id=401024) [details]
> Patch mn1.0 Hide unnecessary menu item in SeaMonkey.
>
> SeaMonkey doesn't need this menu item in the New Message popup since it already
> has it's own menu items there. I hope I've chosen a suitable reviewer.
As far as I can see the menu item you are trying to hide only shows in SeaMonkey anyway, <menupopup id="button-newMsgPopup"> is not present in Thunderbird - http://mxr.mozilla.org/comm-central/search?string=button-newMsgPopup&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
So just remove that menuitem from lightning's messenger-overlay-toolbar.xul
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=401024) [details] [details]
> > Patch mn1.0 Hide unnecessary menu item in SeaMonkey.
> >
> > SeaMonkey doesn't need this menu item in the New Message popup since it already
> > has it's own menu items there. I hope I've chosen a suitable reviewer.
>
> As far as I can see the menu item you are trying to hide only shows in
> SeaMonkey anyway, <menupopup id="button-newMsgPopup"> is not present in
> Thunderbird -
> http://mxr.mozilla.org/comm-central/search?string=button-newMsgPopup&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
> So just remove that menuitem from lightning's messenger-overlay-toolbar.xul
Sorry scrap that, the toolbarbutton id is the same so it still is used in TB.
Is preprocessing the messenger-overlay-toolbar.xul file an option?
Reporter | ||
Comment 5•15 years ago
|
||
> So just remove that menuitem from lightning's messenger-overlay-toolbar.xul
????? The Lightning people will be terribly upset!
> Sorry scrap that, the toolbarbutton id is the same so it still is used in TB.
Phew!
Reporter | ||
Comment 6•15 years ago
|
||
Comment on attachment 401024 [details] [diff] [review]
Patch mn1.0 Hide unnecessary menu item in SeaMonkey.
changing reviewer.
Attachment #401024 -
Flags: review?(philipp) → review?(mschroeder)
Comment 7•15 years ago
|
||
Comment on attachment 401024 [details] [diff] [review]
Patch mn1.0 Hide unnecessary menu item in SeaMonkey.
I talked to Fallen (Philipp) about this approach, and we decided that it would be better if Seamonkey-specific code could live in its own file(s).
Attachment #401024 -
Flags: review?(mschroeder) → review-
<NeilAway> IanN: hmm, well we could add a dummy <menuitem id="newMsgButton-mail-menuitem" hidden="true"/> for Lightning to overlay
Reporter | ||
Comment 9•15 years ago
|
||
> <NeilAway> IanN: hmm, well we could add a dummy <menuitem
> id="newMsgButton-mail-menuitem" hidden="true"/> for Lightning to overlay
This patch uses an overlay to hide the menu item.
Attachment #401024 -
Attachment is obsolete: true
Attachment #405777 -
Flags: review?(mschroeder)
Assignee | ||
Comment 10•15 years ago
|
||
As an alternative add the menuitem to SM's mailWindowOverlay.xul instead.
Attachment #405778 -
Flags: review?(neil)
Updated•15 years ago
|
Attachment #405778 -
Flags: review?(neil) → review+
Updated•15 years ago
|
Assignee: philip.chee → iann_bugzilla
Component: Lightning: SeaMonkey Integration → MailNews: General
Product: Calendar → SeaMonkey
QA Contact: lightning-seamonkey → mail
Attachment #405778 -
Flags: superreview?(neil)
Attachment #405778 -
Flags: approval-seamonkey2.0?
Assignee | ||
Comment 11•15 years ago
|
||
Comment on attachment 405778 [details] [diff] [review]
Add menuitem to SM's mailWindowOverlay patch 2.0 alternative [Checkin: Comment 15]
Very low risk fix to give better lightning integration.
Updated•15 years ago
|
Attachment #405778 -
Flags: superreview?(neil) → superreview+
Reporter | ||
Updated•15 years ago
|
Attachment #405777 -
Attachment is obsolete: true
Attachment #405777 -
Flags: review?(mschroeder)
Reporter | ||
Comment 12•15 years ago
|
||
> + <menuitem id="newMsgButton-mail-menuitem" hidden="true"/>
Shouldn't this follow the "one attribute per line" rule?
Assignee | ||
Comment 13•15 years ago
|
||
(In reply to comment #12)
> > + <menuitem id="newMsgButton-mail-menuitem" hidden="true"/>
>
> Shouldn't this follow the "one attribute per line" rule?
Usually only if the whole element does not fit on one line.
Updated•15 years ago
|
Attachment #405778 -
Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
Comment 14•15 years ago
|
||
Comment on attachment 405778 [details] [diff] [review]
Add menuitem to SM's mailWindowOverlay patch 2.0 alternative [Checkin: Comment 15]
I don't really like tweaks in SeaMonkey for a specific thing in a specific add-on, but I guess I'll need to swallow that one...
Assignee | ||
Comment 15•15 years ago
|
||
Comment on attachment 405778 [details] [diff] [review]
Add menuitem to SM's mailWindowOverlay patch 2.0 alternative [Checkin: Comment 15]
http://hg.mozilla.org/comm-central/rev/18a99eeca8b2
Attachment #405778 -
Attachment description: Add menuitem to SM's mailWindowOverlay patch 2.0 alternative → Add menuitem to SM's mailWindowOverlay patch 2.0 alternative [Checkin: Comment 15]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed-seamonkey2.0
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•