Open Bug 516913 Opened 11 years ago Updated 7 years ago

Support for Additional SEED Cipher Suites to TLS RFC4162

Categories

(NSS :: Libraries, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: bluecey, Assigned: bluecey)

References

Details

(Whiteboard: Additional patch needed to add testing to test scripts)

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; InfoPath.2; .NET CLR 3.5.21022; OfficeLiveConnector.1.4; OfficeLivePatch.0.0; .NET CLR 3.5.30729; .NET CLR 3.0.30618)
Build Identifier: 

After creating TLS_RSA_WITH_SEED_CBC_SHA(BUG 478839), we recently created a new patch including TLS_RSA_WITH_SEED_CBC_SHA, TLS_DHE_DSS_WITH_SEED_CBC_SHA and
TLS_DHE_RSA_WITH_SEED_CBC_SHA.

This is an additional process for enabling two the ciphersuites.

Reproducible: Didn't try
Attached patch Patch V1 (obsolete) — Splinter Review
Comment on attachment 400965 [details] [diff] [review]
Patch V1

This patch modifies files in two different Mozilla source code modules which have two separate sets of reviewers.  I will review the part of this patch that touches files in the NSS source code module.  Then, if it passes that review, I will ask for a separate review of the patch to the PSM files.
Attachment #400965 - Flags: review?(nelson)
I confirm that this is an enhancement request. :)
Assignee: nobody → bluecey
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Target Milestone: --- → 3.13
Version: unspecified → trunk
Attached patch Patch V2 (obsolete) — Splinter Review
I'm so sorry.  We have some problem in patch file, line 90-91. So we upload the new patch file.
Attachment #400965 - Attachment is obsolete: true
Attachment #400965 - Flags: review?(nelson)
Attachment #401167 - Flags: review?(nelson)
Comment on attachment 401167 [details] [diff] [review]
Patch V2

OK, I'll ask myself to review this patch instead. 
I'm glad you're testing your patch!
Attachment #401167 - Flags: review?(nelson) → review+
Comment on attachment 401167 [details] [diff] [review]
Patch V2

This patch includes parts for NSS and parts for PSM.
The parts for PSM should be attached to a separate bug that should be filed against product Core, component security/PSM.  
This review is only for the parts of this patch that are for NSS.

This patch is fine, as far as it goes, but it does not add any testing of the new cipher suites to the testing scripts. 
This patch does not need to be resubmitted, but an additional patch that adds testing to the SSL test script must be submitted before this can be committed.  

r=nelson for 3.13, conditional upon the subsequent submission and approval of a patch for the test script(s).
Whiteboard: Additional patch needed to add testing to test scripts
Attached patch Patch V3Splinter Review
In Patch V3, The part related PSM has been deleted from Patch V2.
We will submit new bug for another part of this patch.
Lee Hosub & Bluecey,
This bug has been waiting for 6 months now for one of you to attach a patch
to it that will test the new cipher suites in the NSS SSL test script(s). 
We won't commit the patch to add the new cipher suites until we know they're
being tested and passing the tests.
Attachment #401167 - Attachment is obsolete: true
Target Milestone: 3.13 → ---
You need to log in before you can comment on or make changes to this bug.