516958 - Remove folder creation from bookmark system

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

For Fennec 1.0, we are removing the capability of creating new folders. Folders will still exist and users can navigate through folders (Weave and over methods can put bookmark folders into Fennec).

* Remove the "New Folder" button when in manage mode
* Remove the Folder List XUL and helper JS code
* Do not remove support for displaying and navigating folders

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Also:
* Remove the "Move" button from the bookmark editing widget

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch removes the UI and code for creating folders and moving bookmarks around folders

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 401015 [details] [diff] [review]
patch

That's a cleanup!

Nits:
#folder-items : i think we can remove the css rules
 * themes/wince/browser.css:#bookmark-items, #folder-items {
 * themes/hildon/browser.css:#bookmark-items, #folder-items {

# remove the call to FolderPicker.show in browser.xul
430                  onmove="FolderPicker.show(this);"

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

removed the other CSS bits and the "onmove" handler.

pushed:
https://hg.mozilla.org/mobile-browser/rev/494da9a04d99

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

verified on my n810 with 20090921 1.9.2 nightly build