Closed
Bug 517061
Opened 16 years ago
Closed 15 years ago
DownloadFile step shouldn't use setBuild()
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Assigned: catlee)
References
Details
(Whiteboard: [simple])
Attachments
(1 file, 1 obsolete file)
|
4.82 KB,
patch
|
bhearsum
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Because DownloadFile does most of its work in setBuild, it can't use properties that are set during a build.
It should do all its magic in start()
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → catlee
Component: Release Engineering: Future → Release Engineering
|
|
Assignee | |
Updated•15 years ago
|
Assignee: catlee → nobody
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [simple]
|
|
Assignee | |
Comment 2•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Attachment #432806 -
Flags: review?(bhearsum)
|
||
Updated•15 years ago
|
Attachment #432806 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → catlee
Priority: P5 → P3
|
|
Assignee | |
Comment 3•15 years ago
|
||
Whoops, the other patch was a busted result of a bad merge.
Attachment #432806 -
Attachment is obsolete: true
Attachment #433328 -
Flags: review?(bhearsum)
|
|
||
Updated•15 years ago
|
|
|
||
Updated•15 years ago
|
Attachment #433328 -
Flags: review?(bhearsum) → review+
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 433328 [details] [diff] [review]
Do property calculations in start()
changeset: 657:1064fc01f63c
Attachment #433328 -
Flags: checked-in+
|
|
||
Comment 5•15 years ago
|
||
Landed, pm*; talos masters have been reconfiged. Marking this fixed.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•