517100 - [SeaMonkey] reftest: 2 input-text-* fail since landing

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Serge Gautherie (:sgautherie)]

{
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/comm-1.9.1-linux-unittest/build/mozilla/layout/reftests/forms/input-text-baseline-1.xul |
REFTEST TEST-UNEXPECTED-FAIL | file:///builds/slave/comm-1.9.1-linux-unittest/build/mozilla/layout/reftests/forms/input-text-centering-1.xul |
}

"Regression" timeframe:
http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?fromchange=2eb7a1915703&tochange=b7dd9891657f
Obviously,
{
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/80affd399497
Karl Tomlinson - text input reftests
}

Comment 1

[Karl Tomlinson (:karlt)]

Hmm.  Perhaps this change could be outside the AUTOCOMPLETE_OLD_STYLE conditional.

https://bugzilla.mozilla.org/attachment.cgi?id=393472&action=diff#a/toolkit/content/xul.css_sec1

If bug 453827 exists in SeaMonkey, then perhaps a similar rule should be added for its urlbar.

Comment 2

[[e-mail]]

(In reply to comment #1)
> Hmm.  Perhaps this change could be outside the AUTOCOMPLETE_OLD_STYLE
> conditional.
That would seem least unreasonable. (I say unreasonable because it sucks that we have to do this in xul.css at all, as you mentioned in bug 453827.)

Comment 3

[Karl Tomlinson (:karlt)]

I suspect that change won't actually fix bug 453827 in SeaMonkey, and a different change will be needed.

Ideally we'd have different tests for Firefox and SeaMonkey.
(Well not ideal but this is all an unfortunate hack, sorry.)
Maybe the best thing is to just disable these tests but leave this (or another bug) open to record that bug 453827 exists in SeaMonkey.

Comment 4

[[e-mail]]

(In reply to comment #3)
> I suspect that change won't actually fix bug 453827 in SeaMonkey
Why not? It definitely fixes the test, which is a start ;-)

Comment 5

[Serge Gautherie (:sgautherie)]

Ftr, input-text-baseline-1.xul TEST-PASS on our MacOSX box.

Comment 6

[[e-mail]]

Attachment: Proposed patch [Checkin: Comment 10]

Comment 7

[Karl Tomlinson (:karlt)]

Comment on attachment 403114 [details] [diff] [review]
Proposed patch
[Checkin: Comment 10]

(In reply to comment #4)
> (In reply to comment #3)
> > I suspect that change won't actually fix bug 453827 in SeaMonkey
> Why not? It definitely fixes the test, which is a start ;-)

For some reason I thought the autocomplete textboxes or the toolbaritem.chromeclass-location were sufficiently different that this rule wouldn't work, but they look close enough to me now.

http://hg.mozilla.org/releases/mozilla-1.9.1/annotate/15e78acc5aae/browser/base/content/browser.xul#l351
http://hg.mozilla.org/comm-central/annotate/3553cec372de/suite/browser/navigator.xul#l258

http://hg.mozilla.org/releases/mozilla-1.9.1/annotate/15e78acc5aae/toolkit/content/widgets/autocomplete.xml#l57
http://hg.mozilla.org/releases/mozilla-1.9.1/annotate/15e78acc5aae/xpfe/components/autocomplete/resources/content/autocomplete.xml#l16

Should probably get sr; this is for a stable branch.

Comment 8

[[e-mail]]

Comment on attachment 403114 [details] [diff] [review]
Proposed patch
[Checkin: Comment 10]

We'd like to have bug 453827 fixed for us too :-)

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 403114 [details] [diff] [review]
Proposed patch
[Checkin: Comment 10]

Approved for 1.9.1.4, a=dveditz

Comment 10

[[e-mail]]

Pushed changeset 866358b0b6fc to releases/mozilla-1.9.1

Comment 11

[Serge Gautherie (:sgautherie)]

"verified1.9.1.4", per SM tinderboxes.