Closed
Bug 517396
Opened 15 years ago
Closed 15 years ago
Maximized windows collapse to their unmaximized size when moving them by dragging toolbar or statusbar
Categories
(Core :: XUL, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta2-fixed |
People
(Reporter: mstange, Assigned: mstange)
References
(Depends on 1 open bug)
Details
(Keywords: regression, verified1.9.2)
Attachments
(1 file, 1 obsolete file)
8.98 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Make your window small. 2. Click the window's zoom button. 3. Drag the status bar. Expected results: This shouldn't change the window size. Actual results: The window collapses to its previous size. This is most certainly a regression from the patch in bug 429954 that started treating zoomed windows as maximized. Un-maximizing maximized windows before moving them certainly makes sense on Windows, but it doesn't make sense on Mac.
Comment 1•15 years ago
|
||
If bug 517396 is a blocker, this should also be a blocker.
Flags: blocking1.9.2?
Assignee | ||
Comment 2•15 years ago
|
||
Neil, do you think this is the right approach?
Comment 3•15 years ago
|
||
Comment on attachment 408922 [details] [diff] [review] v1: reset the size mode in the platform implementations instead Seems reasonable to me.
Attachment #408922 -
Flags: review?(neil) → review+
Updated•15 years ago
|
Flags: blocking1.9.2? → blocking1.9.2+
Priority: -- → P2
Assignee | ||
Comment 4•15 years ago
|
||
Now with test and indentation style that matches the context. Roc, could you review the widget/ changes?
Attachment #408922 -
Attachment is obsolete: true
Attachment #409303 -
Flags: review?(roc)
Attachment #409303 -
Flags: review?(roc) → review+
This would be pretty easy to write a test for, wouldn't it?
Assignee | ||
Comment 6•15 years ago
|
||
There's a test in that patch. :-)
Assignee | ||
Comment 7•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f8eea9f6143a
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Updated•15 years ago
|
Flags: in-testsuite+
Comment 8•15 years ago
|
||
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091104 Minefield/3.7a1pre ID:20091104031046
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 9•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/79bfa41e64b5
status1.9.2:
--- → final-fixed
Comment 10•15 years ago
|
||
Verified fixed on 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b2pre) Gecko/20091106 Namoroka/3.6b2pre ID:20091106033745
Keywords: verified1.9.2
Comment 11•14 years ago
|
||
Comment on attachment 409303 [details] [diff] [review] v2 >+ var win = wm.getMostRecentWindow("navigator:browser"); >+ var oldX = win.screenX, oldY = win.screenY; ... >+ win.restore(); >+ is(win.outerWidth, oldWidth, "restored window has wrong width"); >+ is(win.outerHeight, oldHeight, "restored window has wrong height"); Unfortunately you didn't check that the window was restored before grabbing the old width/height, so if you run the test in a maximised window it fails...
Comment 12•6 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•