STR: 1. Make your window small. 2. Click the window's zoom button. 3. Drag the status bar. Expected results: This shouldn't change the window size. Actual results: The window collapses to its previous size. This is most certainly a regression from the patch in bug 429954 that started treating zoomed windows as maximized. Un-maximizing maximized windows before moving them certainly makes sense on Windows, but it doesn't make sense on Mac.
If bug 517396 is a blocker, this should also be a blocker.
Created attachment 408922 [details] [diff] [review] v1: reset the size mode in the platform implementations instead Neil, do you think this is the right approach?
Comment on attachment 408922 [details] [diff] [review] v1: reset the size mode in the platform implementations instead Seems reasonable to me.
Created attachment 409303 [details] [diff] [review] v2 Now with test and indentation style that matches the context. Roc, could you review the widget/ changes?
This would be pretty easy to write a test for, wouldn't it?
There's a test in that patch. :-)
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091104 Minefield/3.7a1pre ID:20091104031046
Verified fixed on 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b2pre) Gecko/20091106 Namoroka/3.6b2pre ID:20091106033745
Comment on attachment 409303 [details] [diff] [review] v2 >+ var win = wm.getMostRecentWindow("navigator:browser"); >+ var oldX = win.screenX, oldY = win.screenY; ... >+ win.restore(); >+ is(win.outerWidth, oldWidth, "restored window has wrong width"); >+ is(win.outerHeight, oldHeight, "restored window has wrong height"); Unfortunately you didn't check that the window was restored before grabbing the old width/height, so if you run the test in a maximised window it fails...